Skip to content

fix: resolve relative cache:// paths to absolute before spawning threads #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yannrichet-asnr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve relative cache:// paths to absolute before spawning threads #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions fz/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1488,6 +1488,22 @@ def fzr(
else:
has_input_variables = bool(input_variables)

# Resolve relative cache:// paths to absolute before spawning threads.
# run_local_calculation() calls os.chdir() in worker threads; since CWD is
# process-wide, a relative cache:// path resolved via Path(...).exists() in
# one thread may fail while another thread has changed the CWD.
resolved_calculators = []
Comment on lines +1491 to +1495
for calc in calculators:
if calc.startswith("cache://"):
cache_rel = calc[8:]
cache_path = Path(cache_rel)
if not cache_path.is_absolute():
cache_path = Path(original_cwd) / cache_path
resolved_calculators.append(f"cache://{cache_path.resolve()}")
else:
resolved_calculators.append(calc)
Comment on lines +1497 to +1504
calculators = resolved_calculators

# Compile all combinations directly to result directories, then prepare temp directories
compile_to_result_directories(
input_path, model, input_variables, var_combinations, results_dir
Expand Down
Loading