Skip to content

Fix StableWrapperDrawer null reference when no visible children#5

Merged
quabug merged 1 commit into
mainfrom
fix-drawer
Nov 27, 2025
Merged

Fix StableWrapperDrawer null reference when no visible children#5
quabug merged 1 commit into
mainfrom
fix-drawer

Conversation

@quabug

@quabug quabug commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Summary

  • Fix null reference exception in StableWrapperDrawer when GetVisibleChildren() returns no elements
  • Use SingleOrDefault() instead of Single() with null checks for graceful handling
  • Bump package version to 1.1.2

Test plan

  • Open Unity project with StableReference fields
  • Verify drawer renders correctly for valid references
  • Verify no exceptions when visible children are empty

🤖 Generated with Claude Code

Use SingleOrDefault() instead of Single() and add null checks to
handle cases where GetVisibleChildren() returns no elements.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@quabug quabug self-assigned this Nov 27, 2025
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @quabug, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical null reference exception within the StableWrapperDrawer component, which previously failed when GetVisibleChildren() yielded an empty result. The core change involves enhancing the drawer's resilience by adopting SingleOrDefault() and incorporating explicit null checks, ensuring the component operates without errors even when no children are visible. This fix improves the stability of the Unity Stable Reference package, and the version has been incremented accordingly.

Highlights

  • Null Reference Fix: Resolved a null reference exception in StableWrapperDrawer that occurred when GetVisibleChildren() returned no elements.
  • Robust Child Handling: Implemented SingleOrDefault() instead of Single() along with explicit null checks to gracefully handle scenarios where no visible children are present.
  • Package Version Bump: The package version has been updated from 1.1.1 to 1.1.2 to reflect this bug fix.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a potential crash in StableWrapperDrawer when a property has no visible children by using SingleOrDefault() and adding null checks. The package version is also appropriately bumped. My review includes a couple of suggestions to improve code clarity and maintainability by avoiding parameter reassignment. Overall, a good fix.

@quabug
quabug merged commit cfab26f into main Nov 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant