Skip to content

fix(mcp): tolerate empty create task calls#68

Merged
FujiwaraChoki merged 1 commit into
mainfrom
codex/fix-mcp-create-schema
Jun 29, 2026
Merged

fix(mcp): tolerate empty create task calls#68
FujiwaraChoki merged 1 commit into
mainfrom
codex/fix-mcp-create-schema

Conversation

@FujiwaraChoki

Copy link
Copy Markdown
Owner

Summary

  • make supoclip_create_clip_task tolerate empty argument objects instead of failing MCP validation
  • add supoclip_create_clip as a minimal compatibility alias with a single url string

Verification

  • cd mcp && uv run python -m compileall src
  • local list_tools shows no required field for create tools
  • local empty call returns a normal missing-url message instead of a Pydantic validation error

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
supoclip Ready Ready Preview, Comment Jun 29, 2026 4:04pm

Request Review

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

cleaned_title = title.strip()

P2 Badge Handle null optional strings before stripping

When an MCP client sends optional fields explicitly as null (for example {"url": "https://...", "title": null}), this now reaches .strip() and returns an unexpected AttributeError instead of creating the task without a title; the previous Optional[str] signature accepted this case. The same nullable-string pattern also applies to the optional font fields below, so normalize with (value or "") before stripping.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@FujiwaraChoki
FujiwaraChoki merged commit 8655238 into main Jun 29, 2026
6 checks passed
@FujiwaraChoki
FujiwaraChoki deleted the codex/fix-mcp-create-schema branch June 29, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant