fix(mcp): simplify create task schema#65
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0042f7c17
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| normalized_format = output_format if output_format in VALID_OUTPUT_FORMATS else "vertical" | ||
|
|
||
| source: dict = {"url": cleaned_url[:2000]} | ||
| cleaned_title = title.strip() |
There was a problem hiding this comment.
Handle null optional string arguments
When an existing MCP client sends JSON null for optional fields that the previous schema explicitly allowed (for example title, and similarly font_family/font_color below), the tool now calls .strip() on None and returns an unexpected AttributeError before it ever reaches auth or the backend. This breaks callers that still serialize omitted optional parameters as null; normalize these the same way url and caption_template already do, e.g. via (title or "").strip().
Useful? React with 👍 / 👎.
Summary
Verification