Skip to content

fix(mcp): simplify create task schema#65

Merged
FujiwaraChoki merged 1 commit into
mainfrom
codex/fix-mcp-create-schema
Jun 29, 2026
Merged

fix(mcp): simplify create task schema#65
FujiwaraChoki merged 1 commit into
mainfrom
codex/fix-mcp-create-schema

Conversation

@FujiwaraChoki

Copy link
Copy Markdown
Owner

Summary

  • flatten supoclip_create_clip_task parameters to simple JSON-schema types
  • keep backend validation/sanitization inside the tool
  • avoid nullable/Annotated schema shapes that remote MCP clients may drop

Verification

  • cd mcp && uv run python -m compileall src
  • local list_tools shows supoclip_create_clip_task requires url with plain string schema
  • local call_tool with url reaches auth handling instead of url-missing validation

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
supoclip Ready Ready Preview, Comment Jun 29, 2026 12:30am

Request Review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e0042f7c17

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

normalized_format = output_format if output_format in VALID_OUTPUT_FORMATS else "vertical"

source: dict = {"url": cleaned_url[:2000]}
cleaned_title = title.strip()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Handle null optional string arguments

When an existing MCP client sends JSON null for optional fields that the previous schema explicitly allowed (for example title, and similarly font_family/font_color below), the tool now calls .strip() on None and returns an unexpected AttributeError before it ever reaches auth or the backend. This breaks callers that still serialize omitted optional parameters as null; normalize these the same way url and caption_template already do, e.g. via (title or "").strip().

Useful? React with 👍 / 👎.

@FujiwaraChoki
FujiwaraChoki merged commit 6b2fa39 into main Jun 29, 2026
6 checks passed
@FujiwaraChoki
FujiwaraChoki deleted the codex/fix-mcp-create-schema branch June 29, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant