Add configurable reviewer handoff for PR delivery#33
Closed
Fuiste wants to merge 4 commits into
Closed
Conversation
Fuiste
commented
Apr 13, 2026
Fuiste
left a comment
Owner
Author
There was a problem hiding this comment.
I found two blocking issues in the handoff flow.
src/night_shift/infra/task_delivery.gleam:67-92renders the handoff body beforegithub.open_or_update_prreturns the PR identity, butsrc/night_shift/domain/pr_handoff.gleam:128-133printstask.pr_numberin the default stack-context block. On first deliverytask.pr_numberis still empty, so new PRs will publishPR: (none)in the handoff body until a later redelivery updates it.src/night_shift/github.gleam:107-128only searches the result ofissue_comments, andsrc/night_shift/github.gleam:384-399fetches a single/issues/{n}/commentspage with no pagination. Once a PR has enough issue comments for the managed handoff comment to fall off page 1,upsert_handoff_commentwill stop finding it and create duplicates, which breaks the "update in place instead of adding comment noise" contract documented in this PR.
Owner
Author
|
QA completed on the combined stack branch and the work has been superseded by #35. What I validated:
Closing this PR in favor of the QAed combined branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[handoff]settings for PR-body overlays, provenance detail, optional managed comments, and repo-owned snippet pathsTesting
gleam test