Add trust-oriented provenance and recovery surfaces to Night Shift#32
Closed
Fuiste wants to merge 4 commits into
Closed
Add trust-oriented provenance and recovery surfaces to Night Shift#32Fuiste wants to merge 4 commits into
Fuiste wants to merge 4 commits into
Conversation
Fuiste
commented
Apr 13, 2026
Fuiste
left a comment
Owner
Author
There was a problem hiding this comment.
I found one blocking issue in the recovery path.
src/night_shift/usecase/doctor.gleam:188-191asksgit.has_changesto log intofilepath.join(task.worktree_path, ".night-shift-doctor.log"). Butsrc/night_shift_shell.erl:57-65truncates or creates the log file before the command runs. On an otherwise clean interrupted worktree, the probe itself therefore creates an untracked file inside the worktree, andgit status --short --untracked-files=allreports dirty. That meansdoctorwill classify clean running tasks asmanual_attentioninstead ofsafe_to_resume, which defeats the main purpose ofresume --explain/doctor. The log needs to live outside the inspected worktree (for example under the run'slogs/directory).
Owner
Author
|
QA completed on the combined stack branch and the work has been superseded by #35. What I validated:
Closing this PR in favor of the QAed combined branch. |
Fuiste
added a commit
that referenced
this pull request
Apr 14, 2026
Merge QAed stack for PRs #32-34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
night-shift provenance,night-shift doctor, andnight-shift resume --explainprovenance.jsonand surface confidence posture instatus,report, and dashboard payloadsTesting
gleam test