fix(release): only show "New Contributors" for genuine first-timers#105
Merged
Conversation
The contributor-attribution step injected a "## New Contributors"
section for ANY external contributor, not just first-time ones.
first_time only changed the bullet wording ("made their first
contribution" vs "contributed in"), but the section header always
said "New Contributors" — so returning contributors (e.g. @rbb-dev
in #104, who already had #103 merged) were mislabeled as new.
Now the section is only emitted when CONTRIBUTOR_FIRST_TIME=true.
Returning contributors are already credited via their PR in the
changelog and don't need a separate callout.
Also fixed the already-published release-2026.07.09 body by removing
the incorrect "New Contributors" section.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release workflow's contributor-attribution step injected a
## New Contributorssection for any external contributor, not just first-time ones. Thefirst_timeflag only changed the bullet wording ("made their first contribution 🎉"vs"contributed in"), but the section header always said "New Contributors".This caused returning contributors to be mislabeled as new. Example:
@rbb-devcontributed #103 (released inrelease-2026.07.02), then #104 — butrelease-2026.07.09listed them under "New Contributors" again.Fix
Only emit the
## New Contributorssection whenCONTRIBUTOR_FIRST_TIME=true. Returning contributors are already credited via their PR in the changelog and don't need a separate (incorrectly-labeled) callout.Before:
After:
Already-fixed artifact
The already-published
release-2026.07.09body had the incorrect section; it was edited in-place to remove the## New Contributorsblock (rbb-dev is not new — #103 was their first, inrelease-2026.07.02).Verification
release-2026.07.02(rbb-dev Restore DOCX & XLSX export on Open WebUI 0.10.x (+ opt-in external images) #103): correctly says "made their first contribution in Restore DOCX & XLSX export on Open WebUI 0.10.x (+ opt-in external images) #103 🎉" ✅release-2026.07.09(rbb-dev fix(export_to_docx): render Mermaid diagrams with <br> labels — v0.5.2 #104): now has no "New Contributors" section ✅