Skip to content

fix(release): only show "New Contributors" for genuine first-timers#105

Merged
Fu-Jie merged 1 commit into
mainfrom
fix/release-new-contributor-logic
Jul 9, 2026
Merged

fix(release): only show "New Contributors" for genuine first-timers#105
Fu-Jie merged 1 commit into
mainfrom
fix/release-new-contributor-logic

Conversation

@Fu-Jie

@Fu-Jie Fu-Jie commented Jul 9, 2026

Copy link
Copy Markdown
Owner

Problem

The release workflow's contributor-attribution step injected a ## New Contributors section for any external contributor, not just first-time ones. The first_time flag only changed the bullet wording ("made their first contribution 🎉" vs "contributed in"), but the section header always said "New Contributors".

This caused returning contributors to be mislabeled as new. Example: @rbb-dev contributed #103 (released in release-2026.07.02), then #104 — but release-2026.07.09 listed them under "New Contributors" again.

Fix

Only emit the ## New Contributors section when CONTRIBUTOR_FIRST_TIME=true. Returning contributors are already credited via their PR in the changelog and don't need a separate (incorrectly-labeled) callout.

Before:

if [ "$CONTRIBUTOR_IS_EXTERNAL" = "true" ] && ...; then
    echo "## New Contributors" >> release_notes.md   # ← always "New Contributors"
    if [ "$CONTRIBUTOR_FIRST_TIME" = "true" ]; then
        echo "* @... made their first contribution ..."   # first-timer
    else
        echo "* @... contributed in #..."                 # returning (wrong header!)
    fi
fi

After:

if [ "$CONTRIBUTOR_IS_EXTERNAL" = "true" ] && [ "$CONTRIBUTOR_FIRST_TIME" = "true" ] && ...; then
    echo "## New Contributors" >> release_notes.md
    echo "* @... made their first contribution in #... 🎉"
fi

Already-fixed artifact

The already-published release-2026.07.09 body had the incorrect section; it was edited in-place to remove the ## New Contributors block (rbb-dev is not new — #103 was their first, in release-2026.07.02).

Verification

The contributor-attribution step injected a "## New Contributors"
section for ANY external contributor, not just first-time ones.
first_time only changed the bullet wording ("made their first
contribution" vs "contributed in"), but the section header always
said "New Contributors" — so returning contributors (e.g. @rbb-dev
in #104, who already had #103 merged) were mislabeled as new.

Now the section is only emitted when CONTRIBUTOR_FIRST_TIME=true.
Returning contributors are already credited via their PR in the
changelog and don't need a separate callout.

Also fixed the already-published release-2026.07.09 body by removing
the incorrect "New Contributors" section.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@Fu-Jie
Fu-Jie merged commit 51cdd85 into main Jul 9, 2026
@Fu-Jie
Fu-Jie deleted the fix/release-new-contributor-logic branch July 9, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant