Skip to content

Add parsing for python list#7

Open
NicsTr wants to merge 3 commits into
Frky:masterfrom
NicsTr:patch-1
Open

Add parsing for python list#7
NicsTr wants to merge 3 commits into
Frky:masterfrom
NicsTr:patch-1

Conversation

@NicsTr

@NicsTr NicsTr commented Jun 14, 2017

Copy link
Copy Markdown

Not tested (obviously), hope the unit tests are good enough.

NicsTr added 2 commits June 14, 2017 17:29
Not tested (obviously), hope the unit tests are good enough.
@Frky

Frky commented Jun 14, 2017

Copy link
Copy Markdown
Owner

Fix tests and then retry a PR

@NicsTr

NicsTr commented Jun 14, 2017

Copy link
Copy Markdown
Author

I am sorry but it looks like it is your travis configuration who leads to failures.
I can teach you how to make a proper travis config someday if you want but from now on I only need you to accept this PR.

And I need it done quickly because, even if it might surprise you, the project I am currently working on depends on Confiture.

@Frky

Frky commented Jun 14, 2017

Copy link
Copy Markdown
Owner

Nics,
I'm sorry to hear you are in a hurry, but Confiture is widely used, and we cannot afford to push a version that does not pass our tests. Try to fix them, if you need help you can get support on stackoverflow.
Regards,

The Confiture development team

@NicsTr

NicsTr commented Jun 14, 2017

Copy link
Copy Markdown
Author

Frky,
I am currently in the office with every people on earth who ever use Confiture in a project (we are two, in case you're wondering) and we are a majority agreeing upon the fact that you absolutely need to merge the PR #7 .
Regards,

Half of the population using Confiture.

@Frky

Frky commented Jun 15, 2017

Copy link
Copy Markdown
Owner

You just proved me I was right not accepting your dumbed PR - cf commit dfc449e.

@NicsTr

NicsTr commented Jun 15, 2017

Copy link
Copy Markdown
Author

Don't brag too much about it, you may lose instantly around 50,0% of all the active contributors on this project.

P.S.: Your link is broken, maybe you wanted to show me this : dfc449e ?

@Frky

Frky commented Jun 15, 2017

Copy link
Copy Markdown
Owner

YOUR link is broken.

@NicsTr

NicsTr commented Jun 15, 2017

Copy link
Copy Markdown
Author

Overwriting my comment (and yours) just to discredit me ? That's a childish attitude from you, sir. I expected more from a project's maintainer.

@NicsTr

NicsTr commented Jun 15, 2017

Copy link
Copy Markdown
Author

You know what : I give up. I will change Confiture locally and distribute my modified version directly with my project source code. I feel lucky the MIT licence allows it.

@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky

Frky commented Jun 15, 2017

Copy link
Copy Markdown
Owner

Running away from problems is not the solution.

@Frky Frky reopened this Jun 15, 2017
@NicsTr

NicsTr commented Jun 15, 2017

Copy link
Copy Markdown
Author

I am not running away, I am getting around it.

@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@NicsTr NicsTr closed this Jun 15, 2017
@Frky Frky reopened this Jun 15, 2017
@Bl3f

Bl3f commented Jun 15, 2017

Copy link
Copy Markdown
Contributor

Hello guys, I'm working on a project that can send people into space and we absolutely need to have this PR merged. The coffee machine depends on you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants