Skip to content

Improve graph management and panel pop-outs#14

Merged
Friss merged 2 commits into
mainfrom
codex/manage-popouts-and-chart-controls
Apr 23, 2026
Merged

Improve graph management and panel pop-outs#14
Friss merged 2 commits into
mainfrom
codex/manage-popouts-and-chart-controls

Conversation

@Friss

@Friss Friss commented Apr 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • improve graph panel channel management, drag/drop behavior, zoom-range stats, legend rendering, and resizable embedded gauge/tile layouts
  • add scatter/histogram channel style menus, drag badges, and keep the popped-out graph channel manager usable even when a graph is emptied
  • pop out track maps by default while preserving their home worksheet when saving or docking, and bump the workspace version to 0.2.1

Testing

  • cargo check -p i3rs-app
  • cargo test -p i3rs-app -q

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project to version 0.2.1 and introduces several UI improvements, including a "Manage Channels" window for graphs, drag-and-drop support for channel organization, and resizable graph tiles and embedded gauges. The graph legend now displays min, max, and average statistics for the visible time range, and channel colors are now persisted in histograms and scatter plots. Additionally, track maps now correctly return to their original worksheets after being docked. Feedback includes a suggestion to refine the index calculation for time-range statistics to improve accuracy and a note regarding potential layout issues when the number of graph tiles causes their combined minimum height to exceed the available space.

Comment thread crates/i3rs-app/src/panels/graph.rs
Comment thread crates/i3rs-app/src/panels/graph.rs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de20625eb2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/i3rs-app/src/panels/track_map.rs Outdated
Comment thread crates/i3rs-app/src/panels/graph.rs
@Friss Friss merged commit 62f08b5 into main Apr 23, 2026
8 checks passed
@Friss Friss deleted the codex/manage-popouts-and-chart-controls branch April 23, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant