Refactor ServerProtocolHandlerFactory so it's constructing less of it…#143
Merged
ChadSikorra merged 1 commit intoMay 25, 2026
Merged
Conversation
…s dependencies. Moved more of it to the container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring ServerProtocolHandlerFactory so it's constructing less of its dependencies. Moved more of it to the container. Not much more I can do here because some of this is state dependent so I have to be careful about what comes from the container and what does not. This does mean
ProtocolHandlerProvidernow has a lot of dependencies, but at least that chain is now constructed in the correct spot. There isn't a great way to avoid it.