Modernize Polyglott for current macOS and Swift toolchains#10
Open
Fredmf wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NSTask,@NSApplicationMain, oldNSSpeechSynthesizerattribute access) with current Swift APIs for maintainability.Description
AppDelegateto use@main,Process(instead ofNSTask), modernNSStatusBar/status item APIs, updated action signatures, safer optional handling, voice list sorting, and escaped voice-name handling when writing defaults in shell commands (AppDelegate.swift).NSSpeechSynthesizer.attributes(forVoice:)keys and to build the menu with modern APIs and selectors; added error logging around shell invocation and removed brittle manual menu-item index management (AppDelegate.swift).printlnwith modernprintinvoiceDoc.swift(changedINUKtoIN-UK).XCTestpatterns (XCTAssertTrue,measure {}) inpolyglottTests/polyglottTests.swift.polyglott.xcodeproj/project.pbxproj: updatedLastUpgradeCheck, setMACOSX_DEPLOYMENT_TARGET = 12.0, and addedSWIFT_VERSION = 5.0across relevant build configurations.readme.mdannouncing the community refresh for current Macs.Testing
plutil -lint polyglott/Info.plist polyglottTests/Info.plistpassed withOKfor both plists.xcodebuild -list -project polyglott.xcodeprojbutxcodebuildis not available in this Linux execution environment, so a full macOS build/test run could not be executed here.Codex Task