[codex] Open java.lang for JDK 19 agent startup#1216
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates agent startup module/package opening to support reflective access needed on JDK 19+ (specifically for java.lang.ThreadBuilders$BaseThreadFactory.name), while keeping behavior unchanged on older JDKs.
Changes:
- Import
JdkUtilsand gate additional package opening based on the current Java major version. - When running on JDK 19+, add
java.langto the set of packages opened to the agent during startup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Open the
java.langpackage for the agent when running on JDK 19 or newer so the Java adaptor can accessjava.lang.ThreadBuilders$BaseThreadFactory.name.Impact
This keeps the existing startup package-opening behavior unchanged for older JDKs, while adding the JDK 19+ package needed by the agent startup path.
Validation
git diff --check -- agent/agent-core/src/main/java/org/bithon/agent/starter/AgentStarter.javamvn -q -pl agent/agent-core -am test