Skip to content

Rate limit noisy trace exporter warnings#1211

Open
FrankChen021 wants to merge 1 commit into
masterfrom
codex/rate-limit-trace-logging
Open

Rate limit noisy trace exporter warnings#1211
FrankChen021 wants to merge 1 commit into
masterfrom
codex/rate-limit-trace-logging

Conversation

@FrankChen021

@FrankChen021 FrankChen021 commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • reuse the existing component commons RateLimitedLogger in BrpcTraceMessageExporter
  • rate limit repeated ITraceCollector initialization and trace send warnings to once per minute
  • keep different failure messages separated by using the warning message as the rate-limit key

Testing

  • mvn -pl agent/agent-exporter-brpc -am -DskipTests compile

Copilot AI review requested due to automatic review settings June 12, 2026 07:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces log noise in the BRPC trace exporter by introducing rate-limited warning logs, leveraging the existing RateLimitedLogger from the component-commons module. It targets repeated failures during ITraceCollector initialization and trace send operations.

Changes:

  • Replaced noisy LOG.warn(...) calls with RateLimitedLogger.warn(...) to rate-limit repeated warnings (1-minute interval).
  • Introduced a shared, static RateLimitedLogger instance in BrpcTraceMessageExporter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +95 to +97
RATE_LIMITED_LOG.warn("trace-collector-init:" + e.getMessage(),
"Unable to get remote ITraceCollector service: {}",
e.getMessage());
Comment on lines +130 to +132
RATE_LIMITED_LOG.warn("trace-send:" + e.getMessage(),
"Failed to send tracing: {}",
e.getMessage());
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants