Rate limit noisy trace exporter warnings#1211
Open
FrankChen021 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces log noise in the BRPC trace exporter by introducing rate-limited warning logs, leveraging the existing RateLimitedLogger from the component-commons module. It targets repeated failures during ITraceCollector initialization and trace send operations.
Changes:
- Replaced noisy
LOG.warn(...)calls withRateLimitedLogger.warn(...)to rate-limit repeated warnings (1-minute interval). - Introduced a shared, static
RateLimitedLoggerinstance inBrpcTraceMessageExporter.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+95
to
+97
| RATE_LIMITED_LOG.warn("trace-collector-init:" + e.getMessage(), | ||
| "Unable to get remote ITraceCollector service: {}", | ||
| e.getMessage()); |
Comment on lines
+130
to
+132
| RATE_LIMITED_LOG.warn("trace-send:" + e.getMessage(), | ||
| "Failed to send tracing: {}", | ||
| e.getMessage()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing