Skip to content

fix(security): isolate production browser walks #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FranciscoMateusVG wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(security): isolate production browser walks #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .claude/skills/verify-user-path/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,21 @@ Each drawer contains: email + password + CPF + BetterAuth `user_id` + `volunteer

**Rotation:** Ping Peppy if credentials seem compromised OR the password expires. Don't hand-rotate without coordination — the user_id/volunteer_id stay stable; only the password changes; drawer updates after. Each walker rotates independently.

### Production browser-session hygiene (mandatory)

The shared `playwright-mini` launcher runs Playwright MCP in `--isolated` mode. Do not remove that flag or supply a persistent storage state for a production walk. A production session must never survive into another agent's walk.

Before any production action:

1. Navigate to the canonical production origin and call `/api/auth/get-session` with credentials included.
2. The session result **must be null**. If it is not null, record identity metadata only (expected/observed email or user ID, role, and whether impersonation is active), call `/api/auth/sign-out`, then call `/api/auth/get-session` again.
3. Fail closed unless the second result is null. Do not continue under an inherited session, even when it appears to be the expected role.
4. Authenticate only as the allowlisted walker identity and role named in the BEADS walk plan. A real customer-account walk requires explicit operator authorization and a one-off isolated browser context.

Run cleanup as a `finally` step after every production walk: sign out, verify `/api/auth/get-session` returns null, then call `browser_close`. If cleanup or the final null-session check fails, the walk is incomplete and must be reported as blocked.

BEADS evidence records only the canonical origin, expected and observed identity metadata, role, impersonation state, and the preflight/final null-session results. Never store raw passwords, cookies, session tokens, authorization headers, or localStorage values.

### Layer B — Perform the actual user action

Click the button. Submit the form. Upload the file. Trigger the AI. Whatever the feature IS — do it as a user would.
Expand Down
2 changes: 1 addition & 1 deletion scripts/playwright-mcp-mini.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
# Uses globally installed binary to avoid npx startup delay
exec ssh -o StrictHostKeyChecking=no mini \
"export PATH=/Users/franciscogoncalves/.local/share/fnm/node-versions/v22.22.2/installation/bin:/opt/homebrew/bin:/opt/homebrew/sbin:\$PATH && \
playwright-mcp --browser chromium --viewport-size 1280x720"
playwright-mcp --isolated --browser chromium --viewport-size 1280x720"