fix: improve binary detection with extension whitelist priority#17
Closed
Knowckx wants to merge 1 commit into
Closed
fix: improve binary detection with extension whitelist priority#17Knowckx wants to merge 1 commit into
Knowckx wants to merge 1 commit into
Conversation
- Prioritize known text extensions from languageMap (not binary) - Add KNOWN_BINARY_EXTENSIONS set for common binary formats - Use istextorbinary for content-based detection as fallback - Move file-type magic bytes detection to lowest priority This fixes false positive binary detection for files like .svelte, .vue, .tsx that could be misidentified as binary due to magic bytes matching.
Owner
|
Fixed in #18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes false positive binary detection for files like .svelte, .vue, .tsx that could be misidentified as binary due to magic bytes matching.
修复一个判断二进制的问题 目前.sevelte文件会被判断成二进制