Set white background color for email frame elements#2603
Closed
bengotow wants to merge 1 commit into
Closed
Conversation
Add explicit white background to #inbox-html-wrapper and #inbox-plain-wrapper in the email iframe styles. Previously, the iframe body had `background-color: transparent`, which caused the dark theme's parent background to bleed through un-inverted, resulting in illegible text in emails without explicit background colors. With a white background on the content wrappers, the dark theme's CSS filter inversion (`filter: invert(100%) hue-rotate(180deg)`) correctly inverts white to dark, producing clean dark-on-light rendering. Themes can still override this in their own email-frame.less. Fixes https://community.getmailspring.com/t/poor-text-rendering-in-dark-theme/886 https://claude.ai/code/session_0122psQodPbcN8Zh2AtFNi1N
Contributor
Collaborator
Author
|
I looked at a ton of emails just now and I'm not able to find one that is black-on-black in dark mode, will leave this open for a bit but I think something has changed (possibly in Chromium?) since #2110 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds explicit white background colors to email frame styling to ensure consistent visual appearance across different contexts.
Key Changes
background-color: white;to#inbox-html-wrapperselectorbackground-color: white;to the monospace/pre-formatted text block within the email frameImplementation Details
These background color declarations ensure that the email content wrapper and pre-formatted text areas have a consistent white background, preventing potential transparency or inherited background color issues that could affect readability or visual consistency of email content display.
https://claude.ai/code/session_0122psQodPbcN8Zh2AtFNi1N