TR_186 Add/Modify Contact Screen for PreAlpha#93
Merged
Conversation
renburnett
force-pushed
the
186_contact_screen
branch
from
a95da6b to
f0884d5
Compare
renburnett
requested review from
HsiuYa0,
duskcloudxu,
emarti43,
jacksonrya,
kara-o,
lofiandcode,
nexticodes and
pravalikarouthu
emarti43
approved these changes
Jun 12, 2020
emarti43
left a comment
emarti43
left a comment
Contributor
There was a problem hiding this comment.
Working on my end for iOS and Android 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[TR_186] Add/Modify Contact (Formerly Help) Screen for PreAlpha
NOTE: This PR makes use of code from #39
Please check if the PR fulfills these requirements
Figma
Pre Alpha Update: TR 186
Original Help Screen: TR 127
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Helplink in the menu drawer, they are redirected back to the Donations Screen (their Dashboard).What is the new behavior? (if this is a feature change)
Help Screenwas commented out and replaced with aContact Usscreen. Now when a user clicks theContact Uslink in the menu drawer, they are taken to a prealpha-ready Contact Page.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Images (before/ after screenshots, interaction GIFs, ...)
TODO:
If the user deletes their default iOS email app, a somewhat generic alert modal will popup. We'll likely want to handle this differently in future iterations.