Skip to content

refactor: add const to generated constructors#755

Open
RahmiTufanoglu wants to merge 5 commits intoFlutterGen:mainfrom
RahmiTufanoglu:add-const-to-constructors
Open

refactor: add const to generated constructors#755
RahmiTufanoglu wants to merge 5 commits intoFlutterGen:mainfrom
RahmiTufanoglu:add-const-to-constructors

Conversation

@RahmiTufanoglu
Copy link
Copy Markdown

@RahmiTufanoglu RahmiTufanoglu commented May 1, 2026

What does this change?

Adds const to the private constructors generated by the colors and fonts generators.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@RahmiTufanoglu RahmiTufanoglu changed the title refactor: add const keyword to private constructors in generated colo… refactor: add const to generated constructors May 1, 2026
@AlexV525
Copy link
Copy Markdown
Member

AlexV525 commented May 2, 2026

Hi, I think we can directly move on to abstract final class rather than the improving these old styles. WDYT?

@RahmiTufanoglu
Copy link
Copy Markdown
Author

Hi, I think we can directly move on to abstract final class rather than the improving these old styles. WDYT?

You are right. We should use the new dart coding styles. I will update.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.37%. Comparing base (328547b) to head (8aadb3b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
- Coverage   97.37%   97.37%   -0.01%     
==========================================
  Files          24       24              
  Lines         991      989       -2     
==========================================
- Hits          965      963       -2     
  Misses         26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants