[codex] Refactor PhotosCrop feature tree ownership#312
Merged
Conversation
muukii
force-pushed
the
codex/photoscrop-feature-tree-model
branch
from
c831902 to
6d4eb78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PhotosCropEditingModelas the PhotosCrop policy layer over the generic FeatureTree document.CropViewDocumentso CropView edits through a document boundary instead of depending onEditingStackdirectly.EditingHistoryand expose clearer stack APIs:commitCurrentEditIfNeeded,undo,redo,revertCurrentEdit, andremoveAllHistory.Validation
BrightroomEngineTests: 152 passed on iPhone 17 simulator.BrightroomUIsimulator build: succeeded.SwiftUIDemosimulator build: succeeded.git diff --check: passed.Note:
SwiftUIDemostill reports existing iOS 17onChange(of:perform:)deprecation warnings unrelated to this change.