Skip to content

[codex] Limit crop zoom for mask editing#304

Merged
muukii merged 1 commit into
v5from
codex/v5-crop-max-zoom
Jun 16, 2026
Merged

[codex] Limit crop zoom for mask editing#304
muukii merged 1 commit into
v5from
codex/v5-crop-max-zoom

Conversation

@muukii

@muukii muukii commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a finite maximum crop zoom based on a minimum authored crop-output side length.
  • Clamp programmatic crop zoom to the scroll view's configured zoom range before calculating content offset.
  • Add focused tests for the crop zoom policy on large and small images.

Root Cause

Crop editing allowed an unbounded zoom scale, so users could author a final crop output that was only a few pixels wide or tall. Blur masking uses that final crop output as the tool canvas; once the crop output became extremely small, the tool surface entered huge zoom-scale space and viewport-sized brushes resolved into sub-pixel image-space strokes.

Validation

  • BrightroomEngineTests/CropEditingZoomScaleTests via XcodeBuildMCP: 2 tests passed
  • git diff --check

@muukii muukii marked this pull request as ready for review June 16, 2026 18:43
@muukii muukii merged commit 4b8bb78 into v5 Jun 16, 2026
2 checks passed
@muukii muukii deleted the codex/v5-crop-max-zoom branch June 16, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant