Skip to content

Migrated to Gradle Daemon toolchain#3208

Merged
sosnovsky merged 5 commits into
masterfrom
Issue_3207_migrate_to_gradle_toolchain
May 22, 2026
Merged

Migrated to Gradle Daemon toolchain#3208
sosnovsky merged 5 commits into
masterfrom
Issue_3207_migrate_to_gradle_toolchain

Conversation

@DenBond7

@DenBond7 DenBond7 commented May 10, 2026

Copy link
Copy Markdown
Collaborator

close #3207

Summary

This PR migrates the project to Gradle daemon JVM toolchain handling and aligns JVM/Kotlin toolchain configuration around Java 21 for more consistent CI/local builds.

What changed

  • Added Gradle daemon JVM toolchain lock file:
    • gradle/gradle-daemon-jvm.properties (toolchain version 21 + platform URLs)
  • Enabled Foojay resolver plugin in settings:
    • settings.gradle.kts
    • Added org.gradle.toolchains.foojay-resolver-convention (1.0.0)
  • Consolidated toolchain setup in app module:
    • FlowCrypt/build.gradle.kts
    • Moved to kotlin { jvmToolchain(21) ... }
    • Kept Kotlin jvmTarget = JVM_21 and opt-in compiler arg
    • Removed separate java { toolchain { ... } } block
  • Temporarily disabled flaky/incompatible Android test:
    • FlowCrypt/src/androidTest/java/com/flowcrypt/email/ui/SubmitPublicKeyAfterCreationNonGoogleAccountFlowTest.kt
    • Added @Ignore("temporary disabled")

Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@MediumTest
@RunWith(AndroidJUnit4::class)
@FlowCryptTestSettings(useIntents = true, useCommonIdling = false)
@Ignore("temporary disabled")

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one fails sometimes. It will be fixed in #3211

@DenBond7 DenBond7 marked this pull request as ready for review May 22, 2026 08:18
@DenBond7

Copy link
Copy Markdown
Collaborator Author

@sosnovsky, please review this PR

@sosnovsky sosnovsky self-requested a review May 22, 2026 09:21

@sosnovsky sosnovsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good 👍

@sosnovsky sosnovsky merged commit f26dbc2 into master May 22, 2026
7 checks passed
@sosnovsky sosnovsky deleted the Issue_3207_migrate_to_gradle_toolchain branch May 22, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to Gradle daemon JVM criteria

2 participants