Add setting to disable non-error notifications & Add related API functions

Flow.Launcher.Core/Plugin/JsonRPCV2Models/JsonRPCPublicAPI.cs

@@ -89,6 +89,11 @@ public void ShowMsg(string title, string subTitle, string iconPath, bool useMain
             _api.ShowMsg(title, subTitle, iconPath, useMainWindowAsOwner);
         }
 
+        public void ShowMsg(string title, string subTitle, string iconPath, bool useMainWindowAsOwner = true, bool forceShown = false)
+        {
+            _api.ShowMsg(title, subTitle, iconPath, useMainWindowAsOwner, forceShown);
+        }
+
         public void OpenSettingDialog()
         {
             _api.OpenSettingDialog();

Flow.Launcher.Core/Plugin/PluginInstaller.cs

@@ -99,7 +99,9 @@ await DownloadFileAsync(
         {
             PublicApi.Instance.ShowMsg(
                 Localize.installbtn(),
-                Localize.InstallSuccessNoRestart(newPlugin.Name));
+                Localize.InstallSuccessNoRestart(newPlugin.Name),
+                iconPath: "",
+                forceShown: true);
         }
     }
 
@@ -194,7 +196,9 @@ public static async Task UninstallPluginAndCheckRestartAsync(PluginMetadata oldP
         {
             PublicApi.Instance.ShowMsg(
                 Localize.uninstallbtn(),
-                Localize.UninstallSuccessNoRestart(oldPlugin.Name));
+                Localize.UninstallSuccessNoRestart(oldPlugin.Name),
+                iconPath: "",
+                forceShown: true);
         }
     }
 
@@ -254,7 +258,9 @@ await DownloadFileAsync(
         {
             PublicApi.Instance.ShowMsg(
                 Localize.updatebtn(),
-                Localize.UpdateSuccessNoRestart(newPlugin.Name));
+                Localize.UpdateSuccessNoRestart(newPlugin.Name),
+                iconPath: "",
+                forceShown: true);
         }
     }
 
@@ -298,7 +304,8 @@ where string.Compare(existingPlugin.Metadata.Version, pluginUpdateSource.Version
         {
             if (!silentUpdate)
             {
-                PublicApi.Instance.ShowMsg(Localize.updateNoResultTitle(), Localize.updateNoResultSubtitle());
+                PublicApi.Instance.ShowMsg(Localize.updateNoResultTitle(), Localize.updateNoResultSubtitle(), iconPath: "",
+                    forceShown: true);
             }
             return;
         }
@@ -370,7 +377,9 @@ await DownloadFileAsync(
         {
             PublicApi.Instance.ShowMsg(
                 Localize.updatebtn(),
-                Localize.PluginsUpdateSuccessNoRestart());
+                Localize.PluginsUpdateSuccessNoRestart(),
+                iconPath: "",
+                forceShown: true);
         }
     }
 

Flow.Launcher.Core/Plugin/PluginManager.cs

@@ -312,11 +312,9 @@ public static async Task InitializePluginsAsync(IResultUpdateRegister register)
             if (!_initFailedPlugins.IsEmpty)
             {
                 var failed = string.Join(",", _initFailedPlugins.Values.Select(x => x.Metadata.Name));
-                PublicApi.Instance.ShowMsg(
+                PublicApi.Instance.ShowMsgError(
                     Localize.failedToInitializePluginsTitle(),
-                    Localize.failedToInitializePluginsMessage(failed),
-                    "",
-                    false
+                    Localize.failedToInitializePluginsMessage(failed)
                 );
             }
         }

Flow.Launcher.Core/Updater.cs

@@ -42,7 +42,7 @@ public async Task UpdateAppAsync(bool silentUpdate = true)
             {
                 if (!silentUpdate)
                     _api.ShowMsg(Localize.pleaseWait(),
-                        Localize.update_flowlauncher_update_check());
+                        Localize.update_flowlauncher_update_check(), iconPath: "", forceShown: true);
 
                 using var updateManager = await GitHubUpdateManagerAsync(GitHubRepository).ConfigureAwait(false);
 
@@ -64,7 +64,7 @@ public async Task UpdateAppAsync(bool silentUpdate = true)
 
                 if (!silentUpdate)
                     _api.ShowMsg(Localize.update_flowlauncher_update_found(),
-                        Localize.update_flowlauncher_updating());
+                        Localize.update_flowlauncher_updating(), iconPath: "", forceShown: true);
 
                 await updateManager.DownloadReleases(newUpdateInfo.ReleasesToApply).ConfigureAwait(false);
 

Flow.Launcher.Infrastructure/UserSettings/Settings.cs

@@ -511,6 +511,7 @@ public bool KeepMaxResults
 
         public bool DontPromptUpdateMsg { get; set; }
         public bool EnableUpdateLog { get; set; }
+        public bool EnableSuccessNotification { get; set; } = true;
 
         public bool StartFlowLauncherOnSystemStartup { get; set; } = false;
         public bool UseLogonTaskForStartup { get; set; } = false;

Flow.Launcher.Plugin/Interfaces/IPublicAPI.cs

@@ -136,6 +136,16 @@ public interface IPublicAPI
         /// <param name="useMainWindowAsOwner">when true will use main windows as the owner</param>
         void ShowMsg(string title, string subTitle, string iconPath, bool useMainWindowAsOwner = true);
 
+        /// <summary>
+        /// Show message box
+        /// </summary>
+        /// <param name="title">Message title</param>
+        /// <param name="subTitle">Message subtitle</param>
+        /// <param name="iconPath">Message icon path (relative path to your plugin folder)</param>
+        /// <param name="useMainWindowAsOwner">when true will use main windows as the owner</param>
+        /// <param name="forceShown">when true will force the message to be shown regardless of user settings of `Show success notifications`</param>
+        void ShowMsg(string title, string subTitle, string iconPath, bool useMainWindowAsOwner = true, bool forceShown = false);
+
         /// <summary>
         /// Show message box with button
         /// </summary>
@@ -162,7 +172,6 @@ public interface IPublicAPI
         /// </summary>
         void OpenSettingDialog();
 
-
         /// <summary>
         /// Open plugin setting window for a specific plugin.
         /// Reuses the existing window when that plugin's settings window is already open.

Flow.Launcher/Languages/en.xaml

@@ -125,6 +125,8 @@
     <system:String x:Key="hideOnStartupToolTip">Flow Launcher search window is hidden in the tray after starting up.</system:String>
     <system:String x:Key="hideNotifyIcon">Hide tray icon</system:String>
     <system:String x:Key="hideNotifyIconToolTip">When the icon is hidden from the tray, the Settings menu can be opened by right-clicking on the search window.</system:String>
+    <system:String x:Key="enableSuccessNotification">Show success notifications</system:String>
+    <system:String x:Key="enableSuccessNotificationToolTip">Show success notifications for completed actions like copying text. When disabled, only errors and important alerts will appear.</system:String>
     <system:String x:Key="ignoreAccents">Ignore accents when searching</system:String>
     <system:String x:Key="ignoreAccentsToolTip">Treat accented and unaccented characters as equivalent.</system:String>
     <system:String x:Key="promptIgnoreAccents">Would you like to turn on the option to ignore accents when searching?</system:String>

Flow.Launcher/PublicAPIInstance.cs

@@ -53,7 +53,7 @@ public class PublicAPIInstance : IPublicAPI, IRemovable
         private Updater _updater;
         private Updater Updater => _updater ??= Ioc.Default.GetRequiredService<Updater>();
 
-        private readonly object _saveSettingsLock = new();
+        private readonly Lock _saveSettingsLock = new();
 
         #region Constructor
 
@@ -119,21 +119,30 @@ public void SaveAppAllSettings()
         public Task ReloadAllPluginData() => PluginManager.ReloadDataAsync();
 
         public void ShowMsgError(string title, string subTitle = "") =>
-            ShowMsg(title, subTitle, Constant.ErrorIcon, true);
+            ShowMsg(title, subTitle, Constant.ErrorIcon, useMainWindowAsOwner: true, forceShown:true);
 
         public void ShowMsgErrorWithButton(string title, string buttonText, Action buttonAction, string subTitle = "") =>
-            ShowMsgWithButton(title, buttonText, buttonAction, subTitle, Constant.ErrorIcon, true);
+            ShowMsgWithButton(title, buttonText, buttonAction, subTitle, Constant.ErrorIcon, useMainWindowAsOwner: true);
 
         public void ShowMsg(string title, string subTitle = "", string iconPath = "") =>
-            ShowMsg(title, subTitle, iconPath, true);
+            ShowMsg(title, subTitle, iconPath, useMainWindowAsOwner:true, forceShown:false);
 
-        public void ShowMsg(string title, string subTitle, string iconPath, bool useMainWindowAsOwner = true)
+        public void ShowMsg(string title, string subTitle, string iconPath, bool useMainWindowAsOwner = true) =>
+            ShowMsg(title, subTitle, iconPath, useMainWindowAsOwner: true, forceShown: false);
+
+        public void ShowMsg(string title, string subTitle, string iconPath, bool useMainWindowAsOwner = true, bool forceShown = false)
         {
+            if (!forceShown && !_settings.EnableSuccessNotification &&
+                !string.Equals(iconPath, Constant.ErrorIcon, StringComparison.OrdinalIgnoreCase))
+            {
+                return;
+            }
+
             Notification.Show(title, subTitle, iconPath);
         }
 
         public void ShowMsgWithButton(string title, string buttonText, Action buttonAction, string subTitle = "", string iconPath = "") =>
-            ShowMsgWithButton(title, buttonText, buttonAction, subTitle, iconPath, true);
+            ShowMsgWithButton(title, buttonText, buttonAction, subTitle, iconPath, useMainWindowAsOwner: true);
 
         public void ShowMsgWithButton(string title, string buttonText, Action buttonAction, string subTitle, string iconPath, bool useMainWindowAsOwner = true)
         {

Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml

@@ -92,6 +92,20 @@
                     OnContent="{DynamicResource enable}" />
             </ui:SettingsCard>
 
+            <ui:SettingsCard
+                Margin="0 14 0 0"
+                Description="{DynamicResource enableSuccessNotificationToolTip}"
+                Header="{DynamicResource enableSuccessNotification}">
+                <ui:SettingsCard.HeaderIcon>
+                    <ui:FontIcon Glyph="&#xE91C;" />
+                </ui:SettingsCard.HeaderIcon>
+
+                <ui:ToggleSwitch
+                    IsOn="{Binding Settings.EnableSuccessNotification}"
+                    OffContent="{DynamicResource disable}"
+                    OnContent="{DynamicResource enable}" />
+            </ui:SettingsCard>
+
             <ui:SettingsCard
                 Margin="0 14 0 0"
                 Description="{DynamicResource showAtTopmostToolTip}"

Plugins/Flow.Launcher.Plugin.Explorer/Search/Everything/EverythingDownloadHelper.cs

@@ -42,12 +42,12 @@ public static async Task<string> PromptDownloadIfNotInstallAsync(string installe
         }
 
         api.ShowMsg(Localize.flowlauncher_plugin_everything_installing_title(),
-            Localize.flowlauncher_plugin_everything_installing_subtitle(), "", useMainWindowAsOwner: false);
+            Localize.flowlauncher_plugin_everything_installing_subtitle(), iconPath: "", useMainWindowAsOwner: false, forceShown: true);
 
         await DroplexPackage.Drop(App.Everything1_4_1_1009).ConfigureAwait(false);
 
         api.ShowMsg(Localize.flowlauncher_plugin_everything_installing_title(),
-            Localize.flowlauncher_plugin_everything_installationsuccess_subtitle(), "", useMainWindowAsOwner: false);
+            Localize.flowlauncher_plugin_everything_installationsuccess_subtitle(), iconPath: "", useMainWindowAsOwner: false, forceShown: true);
 
         installedLocation = "C:\\Program Files\\Everything\\Everything.exe";
 

Plugins/Flow.Launcher.Plugin.PluginsManager/PluginsManager.cs

@@ -110,7 +110,7 @@ internal async Task InstallOrUpdateAsync(UserPlugin plugin)
                     return;
                 }
 
-                Context.API.ShowMsg(Context.API.GetTranslation("plugin_pluginsmanager_update_alreadyexists"));
+                Context.API.ShowMsgError(Context.API.GetTranslation("plugin_pluginsmanager_update_alreadyexists"));
                 return;
             }
 
@@ -194,14 +194,18 @@ await DownloadFileAsync(
             {
                 Context.API.ShowMsg(Context.API.GetTranslation("plugin_pluginsmanager_installing_plugin"),
                     string.Format(Context.API.GetTranslation("plugin_pluginsmanager_install_success_restart"),
-                        plugin.Name));
+                        plugin.Name),
+                    iconPath: "",
+                    forceShown: true);
                 Context.API.RestartApp();
             }
             else
             {
                 Context.API.ShowMsg(Context.API.GetTranslation("plugin_pluginsmanager_installing_plugin"),
                     string.Format(Context.API.GetTranslation("plugin_pluginsmanager_install_success_no_restart"),
-                        plugin.Name));
+                        plugin.Name),
+                    iconPath: "",
+                    forceShown: true);
             }
         }
 
@@ -383,7 +387,9 @@ await DownloadFileAsync(
                                                 string.Format(
                                                     Context.API.GetTranslation(
                                                         "plugin_pluginsmanager_update_success_restart"),
-                                                    x.Name));
+                                                    x.Name),
+                                                iconPath: "",
+                                                forceShown: true);
                                             Context.API.RestartApp();
                                         }
                                         else
@@ -393,7 +399,9 @@ await DownloadFileAsync(
                                                 string.Format(
                                                     Context.API.GetTranslation(
                                                         "plugin_pluginsmanager_update_success_no_restart"),
-                                                    x.Name));
+                                                    x.Name),
+                                                iconPath: "",
+                                                forceShown: true);
                                         }
                                     }
                                 }
@@ -510,15 +518,19 @@ await DownloadFileAsync(
                             Context.API.ShowMsg(Context.API.GetTranslation("plugin_pluginsmanager_update_title"),
                                 string.Format(
                                     Context.API.GetTranslation("plugin_pluginsmanager_update_all_success_restart"),
-                                    resultsForUpdate.Count));
+                                    resultsForUpdate.Count),
+                                iconPath: "",
+                                forceShown: true);
                             Context.API.RestartApp();
                         }
                         else
                         {
                             Context.API.ShowMsg(Context.API.GetTranslation("plugin_pluginsmanager_update_title"),
                                 string.Format(
                                     Context.API.GetTranslation("plugin_pluginsmanager_update_all_success_no_restart"),
-                                    resultsForUpdate.Count));
+                                    resultsForUpdate.Count),
+                                iconPath: "",
+                                forceShown: true);
                         }
 
                         return true;
@@ -809,7 +821,9 @@ internal List<Result> RequestUninstall(string search)
                                         string.Format(
                                             Context.API.GetTranslation(
                                                 "plugin_pluginsmanager_uninstall_success_no_restart"),
-                                            x.Metadata.Name));
+                                            x.Metadata.Name),
+                                        iconPath: "",
+                                        forceShown: true);
                                 }
 
                                 return true;