Fix invalid locations alert message#14
Open
jseremba wants to merge 1 commit into
Open
Conversation
jseremba
force-pushed
the
fix/invalidmarkers
branch
from
1028652 to
2698e1b
Compare
akileng56
suggested changes
Jun 18, 2018
| props.locations.forEach((location) => { | ||
| const locations = props.locations; | ||
| const invalidLocations: string[] = []; | ||
| if (locations && locations.length) { |
There was a problem hiding this comment.
This can be if (locations.length > 0) { /// }
| const locations = props.locations; | ||
| const invalidLocations: string[] = []; | ||
| if (locations && locations.length) { | ||
| locations.forEach((location) => { |
There was a problem hiding this comment.
Remove the brackets around locations.forEach( location => { //// });
Author
There was a problem hiding this comment.
Do you mean the curly braces ?
| const invalidLocations: string[] = []; | ||
| if (locations && locations.length) { | ||
| locations.forEach((location) => { | ||
| if (!this.validLocation(location) && location.address) { |
There was a problem hiding this comment.
I think you should start with
if (this.validLocation(location)) { } else if (!this.validLocation(location) && location.address) { } else if (!this.validLocation(location) && !location.address) { }
jseremba
force-pushed
the
fix/invalidmarkers
branch
from
2698e1b to
6b7dce5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.