CLI: update uuid dependency#307
Open
cnharrison wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Obvious Code Review
Verdict: COMMENT — CLEAN
Summary
- Blocker: 0
- High: 0
- Medium: 0
- Suggestion: 1
Suggestion
packages/cli/package.json — uuid does not appear to be directly imported anywhere in packages/cli/src/. Since it lives in dependencies, every npm install flatfile installs it for end users. Two possibilities: (1) it is inlined via a bundled transitive dep (fine as-is), or (2) the direct import was removed in a prior refactor without cleaning up the manifest (in which case dropping it entirely would eliminate the advisory exposure path more permanently). Consider running npx depcheck packages/cli in a follow-up to confirm. Not a blocker for this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The CLI still depends on
uuid^9.0.0, which resolves inside the reported advisory range. Downstream listener repos can inherit that finding throughflatfile -> uuid.What changed
uuiddependency to^11.1.1.@types/uuidbecauseuuidnow ships its own types.flatfile.Validation
uuidfinding.