CLI: update tsup dependency#305
Merged
Merged
Conversation
There was a problem hiding this comment.
Obvious Code Review
Verdict: ✅ CLEAN — no blocking findings
Summary
- Blocker: 0
- High: 0
- Medium: 0
- Suggestion: 2
- Nit: 1
Suggestions
- Advisory citations: The changeset mentions "reported tsup and esbuild advisory ranges" without citing specific CVE or advisory IDs. Worth linking the actual advisory for the audit trail.
- Two-major-version jump (6→8): tsup 8.x has several breaking changes vs 6.x. No updates appear in the diff — confirm a build smoke test was run in to verify identical output.
Nit
- shows bumping . Confirm this is expected and not a stray version from a parallel branch.
mmccooyyy
approved these changes
May 22, 2026
mmccooyyy
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Flatfile CLI's tsup dependency and adds a patch changeset so new installs resolve versions outside the reported tsup and esbuild advisory ranges.
Links