added food scaling from land function#104
Conversation
|
Hi @OttaviaTr! This looks good. |
|
While we don't enforce it too strictly, we try to limit line length to 79 characters or less (See PEP8) Other projects are even more strict and block merging if a PEP8 style test is not passed. In this case only docstrings seem to be above the limit, so it is just a matter of adding line breaks to the longer parameter descriptions |
multiple sum Co-authored-by: Juan Pablo Cordero <34517350+jucordero@users.noreply.github.com>
Co-authored-by: Juan Pablo Cordero <34517350+jucordero@users.noreply.github.com>
removed land_dimension option Co-authored-by: Juan Pablo Cordero <34517350+jucordero@users.noreply.github.com>
Co-authored-by: Juan Pablo Cordero <34517350+jucordero@users.noreply.github.com>
Co-authored-by: Juan Pablo Cordero <34517350+jucordero@users.noreply.github.com>
Co-authored-by: Juan Pablo Cordero <34517350+jucordero@users.noreply.github.com>
Co-authored-by: Juan Pablo Cordero <34517350+jucordero@users.noreply.github.com>
|
Hi @OttaviaTr, It all looks good to me. If at any point we need to make amendments or add more functionality to these functions, we will need a new branch in your fork and a new PR. |
Added food scaling from land function #101