Support subtype INTERNAL fields#41
Closed
Sean-Kenneth-Doherty wants to merge 1 commit into
Closed
Conversation
Collaborator
|
This isn’t the correct solution, because it would apply the same offset fields to all of the different internals. The offset/scale parameters are inherent to the relationship between the part and one specific internal space. |
f19f702 to
8233063
Compare
Author
|
You're right. Copying the existing part I've replaced that with a narrower approach: Reviva now creates a fresh runtime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INTERNALvalues for Reviva's runtime part configINTERNALname synchronized with the selected subtypeoffsetfor part/internal relationships that need themFixes #35.
Validation
git diff --checkdotnet build Reviva.sln -c Release --no-restore /p:KSPRoot="/home/sean/.local/share/Steam/steamapps/common/Kerbal Space Program": 0 warnings, 0 errorsCaveat
I have not run an in-game shuttle runtime test, so this remains a draft for maintainer review.