Skip to content

Support subtype INTERNAL fields#41

Closed
Sean-Kenneth-Doherty wants to merge 1 commit into
FirstPersonKSP:mainfrom
Sean-Kenneth-Doherty:codex/preserve-internal-config
Closed

Support subtype INTERNAL fields#41
Sean-Kenneth-Doherty wants to merge 1 commit into
FirstPersonKSP:mainfrom
Sean-Kenneth-Doherty:codex/preserve-internal-config

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty commented May 17, 2026

Summary

  • let each selected B9 subtype provide its own nested INTERNAL values for Reviva's runtime part config
  • keep the runtime INTERNAL name synchronized with the selected subtype
  • document how subtype authors can provide fields such as offset for part/internal relationships that need them

Fixes #35.

Validation

  • git diff --check
  • dotnet build Reviva.sln -c Release --no-restore /p:KSPRoot="/home/sean/.local/share/Steam/steamapps/common/Kerbal Space Program": 0 warnings, 0 errors

Caveat

I have not run an in-game shuttle runtime test, so this remains a draft for maintainer review.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty changed the title [codex] Preserve INTERNAL config when switching IVAs Preserve INTERNAL config when switching IVAs May 17, 2026
@JonnyOThan
Copy link
Copy Markdown
Collaborator

This isn’t the correct solution, because it would apply the same offset fields to all of the different internals. The offset/scale parameters are inherent to the relationship between the part and one specific internal space.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty force-pushed the codex/preserve-internal-config branch from f19f702 to 8233063 Compare May 17, 2026 18:58
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty changed the title Preserve INTERNAL config when switching IVAs Support subtype INTERNAL fields May 17, 2026
@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

You're right. Copying the existing part INTERNAL node would apply one part/internal relationship to unrelated IVA selections.

I've replaced that with a narrower approach: Reviva now creates a fresh runtime INTERNAL node, sets the selected internal name, and only copies extra fields from an INTERNAL node nested in that specific subtype's ModuleIVASwitch data. I also added README guidance for configs that need an offset or similar per-subtype field. Build is still clean against the local KSP 1.12.5 setup.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty deleted the codex/preserve-internal-config branch May 18, 2026 02:01
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty restored the codex/preserve-internal-config branch May 18, 2026 02:04
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty deleted the codex/preserve-internal-config branch May 18, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support offset field in PART:INTERNAL

2 participants