Improve ImGui mouse blocking#65
Merged
Merged
Conversation
Owner
|
Could you rebase this? I want to checkif the pipeline works on PRs now |
Contributor
Author
|
:D Also my bad I didn't realize my PR broke the pipeline. I could rebase my other PRs now too if everything is good to go. |
Owner
|
No don't worry the pipeline was broken already lol. I just finally decided to actually fix it. Looks good now 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly to address a click for advancing NPC dialogue not being blocked when unfocusing the ImGui window. I also adjusted the comments because I'm assuming mouse clicks are handled similarly to keyboard and I'm not sure which of down, pressed, released, etc. these bytes correspond to, yet.