Multiple Emoji to clipboard option#149
Open
ijin82 wants to merge 1 commit into
Open
Conversation
FelipeFTN
reviewed
Jul 5, 2026
Comment on lines
+189
to
+198
| if (this._settings.get_boolean("multiple-emoji-to-clipboard")) { | ||
| if (this.emojiCopy._firstRightClick) { | ||
| this.emojiCopy._firstRightClick = false; | ||
| return this.replaceClipboardAndStay(emojiToCopy); | ||
| } else { | ||
| return this.addToClipboardAndStay(emojiToCopy); | ||
| } | ||
| } else { | ||
| return this.addToClipboardAndStay(emojiToCopy); | ||
| } |
Owner
There was a problem hiding this comment.
I think this function can be simplified as this:
Suggested change
| if (this._settings.get_boolean("multiple-emoji-to-clipboard")) { | |
| if (this.emojiCopy._firstRightClick) { | |
| this.emojiCopy._firstRightClick = false; | |
| return this.replaceClipboardAndStay(emojiToCopy); | |
| } else { | |
| return this.addToClipboardAndStay(emojiToCopy); | |
| } | |
| } else { | |
| return this.addToClipboardAndStay(emojiToCopy); | |
| } | |
| let multipleEmojisEnabled = this._settings.get_boolean("multiple-emoji-to-clipboard"); | |
| if (this.emojiCopy._firstRightClick && multipleEmojisEnabled) { | |
| this.emojiCopy._firstRightClick = false; | |
| return this.replaceClipboardAndStay(emojiToCopy); | |
| } | |
| return this.addToClipboardAndStay(emojiToCopy); |
Comment on lines
+189
to
+192
| if (open) { | ||
| this._firstRightClick = true; | ||
| } | ||
|
|
Owner
There was a problem hiding this comment.
I think you could put this logic inside the already existing if (open) statement in line 194
| this._settings = this.getSettings(); | ||
| this.position = this._settings.get_string("position"); | ||
| this._permanentItems = 0; | ||
| this._firstRightClick = true; |
Owner
There was a problem hiding this comment.
Quick question: Why is this _firstightClick variable necessary?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Option to copy multiple Emoji to clipboard without Emoji dialog close