fix(windows): gate active-theme writes with a short update marker - #291
Open
starsstreaming wants to merge 2 commits into
Open
fix(windows): gate active-theme writes with a short update marker#291starsstreaming wants to merge 2 commits into
starsstreaming wants to merge 2 commits into
Conversation
Support optional theme.json video fields, loopback media serving, menu/tray import, poster fallback, and renderer handoff on both platforms. Closes Fei-Away#240.
Write .theme-update-in-progress only around the final image/video/json/css commit so the watcher cannot load a mixed stamp, then clear it on success. Stale markers expire so a crashed writer cannot freeze theme loads forever.
Author
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
Stacked on #290 (
feat/video-backgrounds).Gate Windows active-theme commits with a short-lived
.theme-update-in-progressmarker so the injector watcher cannot load a mixed image/video/json/css stamp mid-write. Large files are prepared first; the marker covers only the final commit window and is cleared on success. Stale markers expire so a crashed writer cannot freeze theme loads forever.叠在 #290 之上。Windows 活动主题提交增加短窗口
.theme-update-in-progress标记，避免观察者读到半套文件；大文件先备妥，标记只罩最终提交瞬间，成功后清除；过期标记不永久卡住加载。Depends on / 依赖: #290 — please merge that first (or merge this only after #290). Base branch for review:
starsstreaming:feat/video-backgrounds.Type / 类型
Platform / 平台
Self-check / 自测
Windows
User-facing
windows/CHANGELOG.mdunder## 未发布(no VERSION bump)Security / 安全
127.0.0.1)Notes / 补充
Behavior
Set-DreamSkinActiveThemewrites marker token around final moves of image/video +theme.json/ cssloadThemerejects while marker is fresh; end-of-load also fails if marker appears mid-readthemeUpdatePendingChecks
node --test windows/tests/injector-bootstrap.test.mjs— passwindows/tests/run-tests.ps1on the next PR (verified rollback) — exit 0git diff --checkclean on commitStack
Environment
starsstreaming:feat/atomic-theme-writes@7702162