fix(windows): enforce theme schemaVersion at runtime - #288
Open
rwang23 wants to merge 2 commits into
Open
Conversation
4 tasks
rwang23
marked this pull request as ready for review
July 27, 2026 18:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
schemaVersion: 1in the Windows runtime loader.Type / 类型
Platform / 平台
Self-check / 自测
Windows (when code under
windows/changes)install/start/verify/restorescripts exercised / 已按改动跑过对应脚本User-facing / 用户可见变更
windows/CHANGELOG.md/ 已更新 changelogSecurity / 安全
127.0.0.1) where applicable / CDP 仍仅本机回环(如适用)Notes / 补充
macOS already requires
raw.schemaVersion === 1; Windows silently treatedmissing, string, and future values as v1. The patch makes the platforms agree.
All tracked theme fixtures declare numeric schema version 1. The former portable
theme-contract issue #63 is closed, so this PR deliberately does not claim to
close it.
Validated on Windows at
main@611c101with:node --check windows/scripts/injector.mjs— passednode --test windows/tests/theme-schema-contract.test.mjs— passedpowershell.exe -NoProfile -ExecutionPolicy RemoteSigned -File windows/tests/run-tests.ps1— passedgit diff --check— passedNo live installer, launcher, or Codex theme was exercised.
Tracking issue / 追踪 Issue
Closes #299