fix(macos): harden renderer visibility verification - #283
Open
rwang23 wants to merge 1 commit into
Open
Conversation
4 tasks
rwang23
marked this pull request as ready for review
July 27, 2026 18:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
Runtime.evaluatefailures during document swaps within the existing bounded deadline.Type / 类型
Platform / 平台
Self-check / 自测
macOS (when code under
macos/changes)macos/tests/run-tests.shpassed / 已通过macos/scripts/doctor-macos.shverify-dream-skin-macos.shor Desktop VerifyUser-facing / 用户可见变更
macos/CHANGELOG.md(andmacos/VERSIONif release-worthy) / 已更新 changelog(发版时再 bump VERSION)Security / 安全
127.0.0.1) where applicable / CDP 仍仅本机回环(如适用)Notes / 补充
Root cause: the previous
box()check accepted any nonzero-size node unless ithad
display:noneorvisibility:hidden, and one transient evaluation erroraborted the entire verify loop.
Changes reject detached, opacity-zero, CSS-hidden,
content-visibility:hidden,and offscreen anchors; use
checkVisibility()when present; and retry until theexisting deadline expires.
Validated on
main@611c101with:node --test macos/tests/renderer-verification.test.mjs— passed (4 tests)macos/scripts/*.sh— passedgit diff --check— passedThe full portable macOS Node suite was attempted on this Windows host. Its new
test passed, while three pre-existing platform-dependent tests could not run
because Windows denied symlink creation or lacks
/bin/bash; macOS CI and areal Verify smoke remain required.
Tracking issue / 追踪 Issue
Closes #294