Minh small bugs#6
Open
minhNgnn wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the conflict style selection step and refines the industry icon logic in the scenario selector, while updating the navigation flow in the configuration panel.
- Replaced the generic industry icon with a mapping of industry names to specific icons in ScenarioSelector.
- Deleted the unused ConflictStyleSelector component and removed its step from the configuration flow.
- Adjusted ConfigurationPanel to a two-step setup and updated button rendering/handlers accordingly.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/components/configuration/ScenarioSelector.tsx | Added industryIcons map and dynamic icon rendering for each industry |
| frontend/src/components/configuration/ConflictStyleSelector.tsx | Removed the entire unused component |
| frontend/src/components/configuration/ConfigurationPanel.tsx | Dropped conflict styles step and revamped navigation buttons |
Comments suppressed due to low confidence (2)
frontend/src/components/configuration/ScenarioSelector.tsx:92
- The dynamic icon selection and fallback logic would benefit from unit tests. Add tests to verify that each known industry name renders the correct icon and that unknown names fall back to the default.
{industries.map((industry) => {
frontend/src/components/configuration/ScenarioSelector.tsx:9
- [nitpick] The
configprop is typed asany, which can hide shape mismatches. Consider defining and using a specific interface (e.g.ScenarioConfig) to improve type safety and maintainability.
config: any;
| {currentStep === 1 && isConfigurationComplete() && ( | ||
| <> | ||
| <Button | ||
| onClick={() => onComplete(config)} |
There was a problem hiding this comment.
The "Run AI vs AI Demo" button is calling onComplete but should likely invoke the quick practice callback (onQuickPractice), while the "Start Practice Session" button triggers onQuickPractice via handleNext. Please swap these handlers so each button calls its intended prop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commits. small bugs so should be safe to merge