Fix refresh! on Windows#265
Draft
davidanthoff wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 87.27% 88.13% +0.86%
==========================================
Files 48 48
Lines 2899 2908 +9
==========================================
+ Hits 2530 2563 +33
+ Misses 369 345 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows
upanddownanderase_linedon't position the cursor at the beginning of the line, so that new output is rendered incorrectly. By usingprev_lineandnext_linethat is fixed.Also changed the semantics of
replace_lineso that it doesn't move the cursor to the next line, that makes things a bit easier.Next testing this on Mac.
This fixes some of the problems on Windows, but not all of them.