Skip to content

Fix refresh! on Windows#265

Draft
davidanthoff wants to merge 2 commits into
FedeClaudi:masterfrom
davidanthoff:fix-live-rewrite-windows
Draft

Fix refresh! on Windows#265
davidanthoff wants to merge 2 commits into
FedeClaudi:masterfrom
davidanthoff:fix-live-rewrite-windows

Conversation

@davidanthoff

@davidanthoff davidanthoff commented Jul 16, 2025

Copy link
Copy Markdown

On Windows up and down and erase_line don't position the cursor at the beginning of the line, so that new output is rendered incorrectly. By using prev_line and next_line that is fixed.

Also changed the semantics of replace_line so that it doesn't move the cursor to the next line, that makes things a bit easier.

Next testing this on Mac.

This fixes some of the problems on Windows, but not all of them.

@codecov

codecov Bot commented Mar 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.13%. Comparing base (440ce2c) to head (9e8f769).
⚠️ Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
src/Live/app.jl 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   87.27%   88.13%   +0.86%     
==========================================
  Files          48       48              
  Lines        2899     2908       +9     
==========================================
+ Hits         2530     2563      +33     
+ Misses        369      345      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant