fix: apply the high quality portraits toggle without a restart#885
Merged
FatCatClient merged 2 commits intoJul 26, 2026
Merged
Conversation
…-Horizon#736) Always extract and store the HQ portrait override (and clear it when a profile no longer has one), and decide at render time whether to show it, so toggling the setting updates avatars everywhere immediately. Also push the setting-gated avatar to the shell window on settings changes so the character tab updates too.
Contributor
FatCatClient
added
Needs testing
Contributor
|
@Kannamoris, could you resolve the merge conflicts so I can test this as if it were merged into |
…aits-live-toggle # Conflicts: # site/character_page/sidebar.vue
FatCatClient
removed
Needs testing
github-project-automation
Bot
moved this from Follow Up Before Release
to Done
in Horizon Releases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HQ portrait setting was only checked at profile-fetch time and its result baked into
character.overrides.avatarUrl, so toggling it did nothing until components were recreated or the app restarted. The override is now always extracted and stored (and cleared when a profile drops its portrait tag), and the setting is checked at render time incharacterImage()and the few places that read the override directly, so the toggle applies immediately everywhere, including the shell window's character tab.Fixes #736