Skip to content

Redesign NUClearNet and rename to nuclearnet #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrentHouliston wants to merge 18 commits into
base: main
Choose a base branch
from

Implement two-flag connection model and multicast broadcast

3c475df
Select commit
Loading
Failed to load commit list.
Open

Redesign NUClearNet and rename to nuclearnet #190

Implement two-flag connection model and multicast broadcast
3c475df
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 27, 2026 in 1m 7s

Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 79 in src/util/network/sock_t.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "operator==" to check object equality, "in6_addr" is not a trivially copyable type without padding. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9KaE8YQNFI7nDte&open=AZ5oA9KaE8YQNFI7nDte&pullRequest=190

Check warning on line 169 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "::" to access "ntohl". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDs1&open=AZ5oA9JpE8YQNFI7nDs1&pullRequest=190

Check warning on line 340 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Local variables should be initialized immediately. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDs8&open=AZ5oA9JpE8YQNFI7nDs8&pullRequest=190

Check warning on line 289 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "reinterpret_cast" with a "static_cast". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oVwH8YhKOTagRYfHT&open=AZ5oVwH8YhKOTagRYfHT&pullRequest=190

Check failure on line 189 in src/nuclearnet/wire_protocol.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JCE8YQNFI7nDsp&open=AZ5oA9JCE8YQNFI7nDsp&pullRequest=190

Check warning on line 482 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "reinterpret_cast" with a safer operation. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDtF&open=AZ5oA9JpE8YQNFI7nDtF&pullRequest=190

Check failure on line 343 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDs_&open=AZ5oA9JpE8YQNFI7nDs_&pullRequest=190

Check warning on line 83 in src/util/network/sock_t.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "::" to access "ntohs". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9KaE8YQNFI7nDtg&open=AZ5oA9KaE8YQNFI7nDtg&pullRequest=190

Check warning on line 405 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::string" instead of a C-style char array. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDtC&open=AZ5oA9JpE8YQNFI7nDtC&pullRequest=190

Check warning on line 39 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not use the constructor's initializer list for data member "discovery". Use the in-class initializer instead. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDsw&open=AZ5oA9JpE8YQNFI7nDsw&pullRequest=190

Check warning on line 277 in src/nuclearnet/Discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

The code of this branch is a duplicate; merge the branches or refactor so that all branches are unique. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oVwHcYhKOTagRYfHQ&open=AZ5oVwHcYhKOTagRYfHQ&pullRequest=190

Check failure on line 237 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDs6&open=AZ5oA9JpE8YQNFI7nDs6&pullRequest=190

Check failure on line 67 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not throw uncaught exceptions in a destructor. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDsy&open=AZ5oA9JpE8YQNFI7nDsy&pullRequest=190

Check warning on line 288 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Local variables should be initialized immediately. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oVwH8YhKOTagRYfHR&open=AZ5oVwH8YhKOTagRYfHR&pullRequest=190

Check warning on line 341 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "reinterpret_cast" with a "static_cast". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDs-&open=AZ5oA9JpE8YQNFI7nDs-&pullRequest=190

Check warning on line 153 in src/nuclearnet/Reliability.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this specialization with "bool" of "std::vector". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JgE8YQNFI7nDsu&open=AZ5oA9JgE8YQNFI7nDsu&pullRequest=190

Check warning on line 112 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "::" to access "htonl". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDs0&open=AZ5oA9JpE8YQNFI7nDs0&pullRequest=190

Check failure on line 67 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not throw uncaught exceptions in a destructor. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDsz&open=AZ5oA9JpE8YQNFI7nDsz&pullRequest=190

Check warning on line 567 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace "reinterpret_cast" with a safer operation. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDtJ&open=AZ5oA9JpE8YQNFI7nDtJ&pullRequest=190

Check failure on line 185 in src/nuclearnet/NUClearNet.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9KCE8YQNFI7nDtU&open=AZ5oA9KCE8YQNFI7nDtU&pullRequest=190

Check warning on line 37 in src/nuclearnet/Reliability.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9KIE8YQNFI7nDtV&open=AZ5oA9KIE8YQNFI7nDtV&pullRequest=190

Check warning on line 43 in src/nuclearnet/wire_protocol.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this "enum" with "enum class". 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JCE8YQNFI7nDsn&open=AZ5oA9JCE8YQNFI7nDsn&pullRequest=190

Check failure on line 291 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oVwH8YhKOTagRYfHU&open=AZ5oVwH8YhKOTagRYfHU&pullRequest=190

Check warning on line 418 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code to remove this break statement. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDtD&open=AZ5oA9JpE8YQNFI7nDtD&pullRequest=190

Check failure on line 581 in src/nuclearnet/NUClearNet.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=Fastcode_NUClear&issues=AZ5oA9JpE8YQNFI7nDtP&open=AZ5oA9JpE8YQNFI7nDtP&pullRequest=190
View more details on SonarQubeCloud