fix(install): ship native fbuild as a raw wheel script (closes #746)

[zackees]

Summary

• Drop the [project.scripts] fbuild = ci.bin_launcher:main Python shim and ship the cargo-built native binary directly via setuptools' scripts= mechanism (fbuild-<ver>.data/scripts/fbuild.exe in the wheel).
• Override build_scripts.copy_scripts so it byte-copies the binary instead of trying to detect a Python coding cookie (SyntaxError).
• Delete ci/bin_launcher.py and drop ci from [tool.setuptools] packages + [tool.setuptools.package-data].

Closes #746.

Why

On Windows, [project.scripts] generates a pip console-script .exe that imports ci.bin_launcher.main, which os.execvs the bundled native binary. POSIX execv replaces the process; Windows os.execv is emulated as CreateProcess + parent exit, so the Python shim returned to cmd.exe before the spawned Rust binary finished flushing stdout — the next shell prompt then raced ahead of fbuild port scan's output. Same mechanism ci/publish.py already uses for the release wheels on PyPI; only the local-install path was wrong.

Test plan

• pip install --force-reinstall . produces Scripts/fbuild.exe that file reports as PE32+ executable (not Zip archive console-script stub).
• cmd /c 'echo === BEFORE === & fbuild port scan & echo === AFTER ===' prints === AFTER === after the scan output, not before.
• fbuild --version / fbuild --help still work.
• from fbuild.api import SerialMonitor still imports (PyO3 bindings unaffected).
• Wheel layout (unzip -l dist/*.whl) shows fbuild-2.2.31.data/scripts/fbuild.exe plus fbuild/, fbuild/api/ packages, and dist-info — no ci/ entries.
• CI green on Linux + macOS + Windows.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores
  • Streamlined the distribution process by directly packaging the native binary without a Python wrapper.
  • Updated build configuration to optimize installation behavior and consistency across platforms.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a5f226b7-a3b6-467d-a290-d7dc8f2348e2

📥 Commits

Reviewing files that changed from the base of the PR and between fd67061 and 7864eb2.

📒 Files selected for processing (3)

• ci/bin_launcher.py
• pyproject.toml
• setup.py

---

📝 Walkthrough

Walkthrough

Removes ci/bin_launcher.py (the Python shim that os.execv-ed into the staged Rust binary) and replaces the [project.scripts] console-script entry point with a setup.py-based raw wheel script delivery. A new BuildBinaryScripts command subclasses build_scripts to byte-copy the staged binary directly into the venv bin//Scripts/ directory without generating a Python wrapper.

Changes

Native Binary Distribution

Layer / File(s)	Summary
Remove console-script entry point and ci package pyproject.toml	Replaces [project.scripts] fbuild = "ci.bin_launcher:main" with comments, removes ci from [tool.setuptools].packages, and drops the ci = ["bin/fbuild*"] package-data entry.
BuildBinaryScripts command and setup() wiring setup.py	Updates module docstring, reorders imports (setuptools before distutils), adds BuildBinaryScripts(build_scripts) with a copy_scripts override that byte-copies binaries (using dep_util or mtime fallback), and registers it via cmdclass with scripts=[str(STAGED_BINARY_PATH)] in setup().

Sequence Diagram(s)

sequenceDiagram
  participant pip
  participant BuildWithCargo
  participant BuildBinaryScripts
  participant venv_bin as venv bin/ or Scripts/

  pip->>BuildWithCargo: build_py — cargo build, stage fbuild into ci/bin/
  BuildWithCargo-->>pip: STAGED_BINARY_PATH available
  pip->>BuildBinaryScripts: build_scripts phase — copy_scripts()
  BuildBinaryScripts->>BuildBinaryScripts: up_to_date check (dep_util / mtime)
  BuildBinaryScripts->>venv_bin: byte-copy fbuild[.exe]
  venv_bin-->>pip: native binary on PATH, no Python shim

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• FastLED/fbuild#458: Also modifies setup.py to build, locate, and stage the compiled Rust fbuild executable into ci/bin/ for wheel installation — directly feeds the path this PR consumes via STAGED_BINARY_PATH.

Poem

🐇 No more Python in the middle lane,
The Rust binary runs, no shim to chain!
execv on Windows? A race we lost —
Now fbuild.exe lands straight, no extra cost.
One hop, not two — the prompt waits its turn,
A native path forward, hard-won and firm! 🥕

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/746-drop-python-shim

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}