chore: tidy up perf-investigation aftermath#745
Conversation
- Stop tracking ad-hoc `port_scan_*.txt` captures. PR #741 added the `fbuild port scan` command; users sometimes redirect its output to a local file for diagnostic comparison. Those captures aren't useful to anyone else and never belonged in the working tree. - Refresh `ci/bench-results/REPORT.md` to cover the full cumulative story after PR #743 and PR #744: - No-source-change reinstall: 14.9s -> 1.1s (13.6x, PR #743). - Real `.rs` edit + uv run: 100.1s -> 18.9s (5.3x, PR #744). - The remaining ~14s touch-only floor is soldr/zccache wrapper overhead; profiled it down to the second and filed upstream as zackees/soldr#883. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds two ChangesHousekeeping and Benchmark Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
port_scan_*.txtcaptures. PR feat(cli): fbuild port scan — enumerate ports + resolve VID:PID to vendor/product via FastLED/boards #741 added thefbuild port scancommand; users sometimes redirect its output for diagnostic comparison. Adds matching.gitignoreentries.ci/bench-results/REPORT.mdto reflect the full cumulative story after both perf PRs:.rsedit +uv run: 100.1s → 18.9s (5.3×, PR perf(build): default to dev profile + rust-lld for ~5x faster Rust-edit rebuild #744)Test plan
port_scan_*.txtpatterns excluded fromgit statusafter creating dummy files🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
uv runand Rust source edits, including rebuilt timing measurements and optimization scenarios.Chores