Skip to content

chore: tidy up perf-investigation aftermath#745

Merged
zackees merged 1 commit into
mainfrom
chore/tidy-perf-report
Jun 22, 2026
Merged

chore: tidy up perf-investigation aftermath#745
zackees merged 1 commit into
mainfrom
chore/tidy-perf-report

Conversation

@zackees

@zackees zackees commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Test plan

  • port_scan_*.txt patterns excluded from git status after creating dummy files
  • Report sections reference the right PR numbers and the live soldr issue link

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation

    • Updated benchmark report documenting performance improvements for uv run and Rust source edits, including rebuilt timing measurements and optimization scenarios.
  • Chores

    • Updated git configuration to exclude local diagnostic capture files.

- Stop tracking ad-hoc `port_scan_*.txt` captures. PR #741 added the
  `fbuild port scan` command; users sometimes redirect its output to a
  local file for diagnostic comparison. Those captures aren't useful
  to anyone else and never belonged in the working tree.

- Refresh `ci/bench-results/REPORT.md` to cover the full cumulative
  story after PR #743 and PR #744:
  - No-source-change reinstall: 14.9s -> 1.1s (13.6x, PR #743).
  - Real `.rs` edit + uv run: 100.1s -> 18.9s (5.3x, PR #744).
  - The remaining ~14s touch-only floor is soldr/zccache wrapper
    overhead; profiled it down to the second and filed upstream as
    zackees/soldr#883.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d5b30b84-61f6-40fa-b322-b7cefce45964

📥 Commits

Reviewing files that changed from the base of the PR and between 5087c8f and cbe30ce.

📒 Files selected for processing (2)
  • .gitignore
  • ci/bench-results/REPORT.md

📝 Walkthrough

Walkthrough

Adds two .gitignore patterns to exclude local fbuild port scan diagnostic output files. Updates ci/bench-results/REPORT.md to document PRs #743 and #744 with a restructured problem statement, new fix descriptions, updated timing tables, and revised reproduction instructions.

Changes

Housekeeping and Benchmark Documentation

Layer / File(s) Summary
Gitignore for port scan output
.gitignore
Adds patterns port_scan_stderr*.txt and port_scan_stdout*.txt with comments to prevent fbuild port scan diagnostic files from being committed.
Benchmark report rewrite
ci/bench-results/REPORT.md
Restructures the report to separate forced reinstall and real Rust edit rebuild problems, documents PR #743 (CARGO_TARGET_DIR pinning and mtime-based cargo skip) and PR #744 (dev build profile defaults, Cargo opt-level, rust-lld Windows linker), and replaces old scenario tables with updated timing measurements, reproduction commands, and file list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 Two little patterns, now safely ignored,
No scan files shall clutter the repo's accord.
The benchmark rewrites with tables anew,
PR seven-four-three and four-four-four too!
Hops along happily, the rabbit's content —
Clean logs and timed builds, well worth the event. 🌿

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/tidy-perf-report

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees merged commit fd67061 into main Jun 22, 2026
84 of 91 checks passed
@zackees zackees deleted the chore/tidy-perf-report branch June 22, 2026 01:42
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant