Skip to content

chore: rename nightly-usb-ids workflow to update-data#716

Merged
zackees merged 1 commit into
mainfrom
chore/rename-update-data-workflow
Jun 20, 2026
Merged

chore: rename nightly-usb-ids workflow to update-data#716
zackees merged 1 commit into
mainfrom
chore/rename-update-data-workflow

Conversation

@zackees

@zackees zackees commented Jun 20, 2026

Copy link
Copy Markdown
Member

Workflow now refreshes multiple datasets, so the file name + display name no longer fit. Rename to update-data.yml / "Update data". Trade-off: existing run history under the old name is stranded in the Actions UI, but new runs appear under the clearer name.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores

    • Renamed GitHub Actions workflow to "Update data" for improved clarity.
  • Documentation

    • Updated documentation and examples to reflect workflow naming changes.

The workflow now refreshes multiple datasets (USB-VID + PlatformIO
boards + slim vendor_boards view), so the file name + display name no
longer reflect its scope. Rename to "Update data" and update the few
docs / source comments that referenced the old name.

Side-effect: GitHub's workflow run history is keyed by file path, so
existing run history under "Nightly USB IDs refresh" becomes stranded
in the Actions UI. New runs appear under "Update data". Acceptable cost
for a clearer name.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9c45cb85-83bf-44e4-951f-f63753b7625d

📥 Commits

Reviewing files that changed from the base of the PR and between 0d6af28 and a8660ed.

📒 Files selected for processing (3)
  • .github/workflows/update-data.yml
  • crates/fbuild-core/examples/dump_usb_ids.rs
  • docs/online-data.md

📝 Walkthrough

Walkthrough

All references to the old "nightly-online-data refresh" / "nightly-usb-ids" naming are renamed to "update-data" across the GitHub Actions workflow file (display name, concurrency group, job key, step summary heading), the online-data documentation (workflow filename and manual trigger label), and the dump_usb_ids.rs example doc comment.

Changes

Workflow rename

Layer / File(s) Summary
Rename workflow name, identifiers, docs, and code comment references
.github/workflows/update-data.yml, docs/online-data.md, crates/fbuild-core/examples/dump_usb_ids.rs
Workflow display name changed to "Update data", concurrency group renamed to update-data, job key/name updated from refresh/Refresh to update/Update, step summary heading updated; docs update the referenced workflow filename from nightly-usb-ids.yml to update-data.yml and the manual trigger label from "Nightly USB IDs refresh" to "Update data"; example doc comment updated to reference .github/workflows/update-data.yml.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A rabbit hops by with a name tag to swap,
"Nightly" felt sleepy, so now we just say "Update"!
The workflow, the docs, and the comment in Rust —
All freshened and tidy, as change-hoppers must.
No logic was harmed in this cosmetic delight,
Just labels rewritten to feel crisp and right! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/rename-update-data-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees merged commit 74f2bd9 into main Jun 20, 2026
83 of 91 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant