Skip to content

fix(hooks): stop triggering full editable rebuild on every Edit/Write #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackees merged 2 commits into from
Jun 20, 2026
Merged

fix(hooks): stop triggering full editable rebuild on every Edit/Write #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d329db4
fix(hooks): stop triggering full editable rebuild on every Edit/Write
zackees Jun 19, 2026
fef4d89
fix(hooks): canonicalize lint path containment
zackees Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .claude/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"hooks": [
{
"type": "command",
"command": "cd \"$(git rev-parse --show-toplevel)\" && uv run --script ci/hooks/board_context.py",
"command": "cd \"$(git rev-parse --show-toplevel)\" && uv run --no-project --script ci/hooks/board_context.py",
"timeout": 5
}
]
Expand All @@ -17,7 +17,7 @@
"hooks": [
{
"type": "command",
"command": "cd \"$(git rev-parse --show-toplevel)\" && uv run --script ci/hooks/tool_guard.py",
"command": "cd \"$(git rev-parse --show-toplevel)\" && uv run --no-project --script ci/hooks/tool_guard.py",
"timeout": 5
}
]
Expand All @@ -29,12 +29,12 @@
"hooks": [
{
"type": "command",
"command": "cd \"$(git rev-parse --show-toplevel)\" && uv run --script ci/hooks/lint.py",
"command": "cd \"$(git rev-parse --show-toplevel)\" && uv run --no-project --script ci/hooks/lint.py",
"timeout": 120
},
{
"type": "command",
"command": "cd \"$(git rev-parse --show-toplevel)\" && uv run --script ci/hooks/readme_guard.py",
"command": "cd \"$(git rev-parse --show-toplevel)\" && uv run --no-project --script ci/hooks/readme_guard.py",
"timeout": 5
}
]
Expand All @@ -45,7 +45,7 @@
"hooks": [
{
"type": "command",
"command": "cd \"$(git rev-parse --show-toplevel)\" && uv run --script ci/hooks/check-on-start.py",
"command": "cd \"$(git rev-parse --show-toplevel)\" && uv run --no-project --script ci/hooks/check-on-start.py",
"timeout": 10
}
]
Expand All @@ -56,12 +56,12 @@
"hooks": [
{
"type": "command",
"command": "cd \"$(git rev-parse --show-toplevel)\" && uv run --script ci/hooks/code-review-on-stop.py",
"command": "cd \"$(git rev-parse --show-toplevel)\" && uv run --no-project --script ci/hooks/code-review-on-stop.py",
"timeout": 10
},
{
"type": "command",
"command": "cd \"$(git rev-parse --show-toplevel)\" && uv run --script ci/hooks/check-on-stop.py",
"command": "cd \"$(git rev-parse --show-toplevel)\" && uv run --no-project --script ci/hooks/check-on-stop.py",
"timeout": 120
}
]
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,4 @@ tasks/loop-runs/
# clud project settings
!.clud/
!.clud/settings.json
.claude/tmp/
23 changes: 17 additions & 6 deletions ci/hooks/lint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,11 @@ def main():
if not file_path:
return 0

# Normalize path
file_path = file_path.replace("\\", "/")

# Resolve relative paths against project root
if not os.path.isabs(file_path):
file_path = os.path.join(str(PROJECT_ROOT), file_path).replace("\\", "/")
file_path = os.path.join(str(PROJECT_ROOT), file_path)

file_path = os.path.realpath(file_path)

# Only lint Rust files
if not file_path.endswith(".rs"):
Expand All @@ -50,10 +49,22 @@ def main():
if not os.path.isfile(file_path):
return 0

# Delegate to ./lint in single-file mode
# Skip files outside this project (e.g. when editing inside a worktree
# of another repo). detect_crate() would otherwise read the worktree's
# `crates/<x>` segment and run clippy with -p <x> against fbuild, which
# either fails or — when names collide — lints the wrong code.
project_root_real = os.path.normcase(os.path.realpath(str(PROJECT_ROOT)))
file_path_check = os.path.normcase(file_path)
if os.path.commonpath([project_root_real, file_path_check]) != project_root_real:
return 0

# Delegate to ./lint in single-file mode. Use the active interpreter
# directly instead of `uv run --script` so we don't trigger another
# editable-build of the fbuild project (which would re-run
# `soldr cargo build --release -p fbuild-cli` on every Edit).
lint_script = str(PROJECT_ROOT / "lint")
result = subprocess.run(
["uv", "run", "--script", lint_script, file_path],
[sys.executable, lint_script, file_path],
capture_output=True,
text=True,
encoding="utf-8",
Expand Down
Loading