Skip to content

feat: match upstream multiple ino ordering#656

Merged
zackees merged 1 commit into
mainfrom
feat/647-multiple-ino-order
Jun 19, 2026
Merged

feat: match upstream multiple ino ordering#656
zackees merged 1 commit into
mainfrom
feat/647-multiple-ino-order

Conversation

@zackees

@zackees zackees commented Jun 19, 2026

Copy link
Copy Markdown
Member

Summary

  • Match upstream multiple-.ino handling by selecting a primary sketch before concatenating additional tabs.
  • Prefer Arduino-style <sketch>/<sketch>.ino, support PlatformIO-style src/main.ino, and fall back to a file containing setup() or loop().
  • Sort additional .ino tabs case-insensitively with exact filename order as a stable tie breaker.
  • Document the Arduino CLI and PlatformIO behavior used for the compatibility decision.

Closes #647

Investigation

  • Arduino CLI documents preprocessing as primary file matching the sketch folder first, followed by remaining .ino/.pde files alphabetically, then adding .cpp to the generated file.
  • PlatformIO's InoToCPPConverter scans top-level PROJECT_SRC_DIR/*.ino/*.pde, moves a file containing setup() or loop() to the front when present, and names the generated output from the selected main .ino path.
  • fbuild now combines those rules for Arduino sketch folders and PlatformIO src/ projects.

Tests

  • soldr cargo fmt
  • soldr cargo test -p fbuild-build source_scanner
  • soldr cargo clippy -p fbuild-build --all-targets -- -D warnings
  • soldr cargo test -p fbuild-build

@zackees zackees merged commit db10481 into main Jun 19, 2026
83 of 90 checks passed
@zackees zackees deleted the feat/647-multiple-ino-order branch June 19, 2026 19:51
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 10 minutes and 2 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6c87833c-64fa-42cb-9671-2071d5dce7df

📥 Commits

Reviewing files that changed from the base of the PR and between 7c5b3eb and df190dc.

📒 Files selected for processing (2)
  • crates/fbuild-build/src/source_scanner.rs
  • docs/reference/platformio-compatibility.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/647-multiple-ino-order

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

feat: match Arduino CLI and PlatformIO behavior for multiple ino files

1 participant