Skip to content

feat: conditionally inject Arduino.h for ino preprocessing#655

Merged
zackees merged 1 commit into
mainfrom
feat/646-conditional-arduino-include
Jun 19, 2026
Merged

feat: conditionally inject Arduino.h for ino preprocessing#655
zackees merged 1 commit into
mainfrom
feat/646-conditional-arduino-include

Conversation

@zackees

@zackees zackees commented Jun 19, 2026

Copy link
Copy Markdown
Member

Summary

  • Make .ino preprocessing inject #include <Arduino.h> only when the active core/variant include roots contain Arduino.h.
  • Keep direct sketch scans header-agnostic, and pass include roots through the full scan and STM32 Arduino mbed path.
  • Add tests for header-present/header-absent output and no-rewrite stability in both modes.

Closes #646

Tests

  • soldr cargo fmt
  • soldr cargo test -p fbuild-build source_scanner
  • soldr cargo test -p fbuild-build script_runtime::tests::test_shim_medium_default_environment_linkflags -- --exact
  • soldr cargo clippy -p fbuild-build --all-targets -- -D warnings
  • soldr cargo test -p fbuild-build

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 31 minutes and 54 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2452015b-da5c-4d5f-ae29-1ecfa10c25ce

📥 Commits

Reviewing files that changed from the base of the PR and between d25c060 and 2dc2a37.

📒 Files selected for processing (2)
  • crates/fbuild-build/src/source_scanner.rs
  • crates/fbuild-build/src/stm32/orchestrator/arduino_mbed.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/646-conditional-arduino-include

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees merged commit 7c5b3eb into main Jun 19, 2026
86 of 95 checks passed
@zackees zackees deleted the feat/646-conditional-arduino-include branch June 19, 2026 19:38
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

feat: make Arduino.h injection conditional during ino preprocessing

1 participant