Skip to content

Rebind serial sessions after USB renumber#643

Merged
zackees merged 1 commit into
mainfrom
fix/serial-session-rebind
Jun 18, 2026
Merged

Rebind serial sessions after USB renumber#643
zackees merged 1 commit into
mainfrom
fix/serial-session-rebind

Conversation

@zackees

@zackees zackees commented Jun 18, 2026

Copy link
Copy Markdown
Member

Closes #642.\n\n## Summary\n- rebind active serial sessions to the new physical port after tracked USB serial renumbering\n- preserve logical session keys, broadcasters, readers, and writer locks across the rebind\n- surface structured port_rebind_failed events when reopening the new port fails\n\n## Tests\n- soldr cargo fmt --all --check\n- soldr cargo check -p fbuild-serial -p fbuild-daemon -p fbuild-python\n- soldr cargo test -p fbuild-serial messages -- --nocapture\n- soldr cargo test -p fbuild-serial manager -- --nocapture\n- soldr cargo test -p fbuild-daemon device_manager -- --nocapture\n- soldr cargo test -p fbuild-daemon handlers::operations::monitor -- --nocapture\n- soldr cargo check -p fbuild-python --all-targets\n- soldr cargo clippy -p fbuild-serial -p fbuild-daemon -p fbuild-python --all-targets -- -D warnings

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 20 minutes and 39 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 32dae496-84e8-49b6-8cde-65bda18cb3a4

📥 Commits

Reviewing files that changed from the base of the PR and between 4c1ea87 and e102ac1.

📒 Files selected for processing (10)
  • crates/fbuild-daemon/src/context.rs
  • crates/fbuild-daemon/src/handlers/devices.rs
  • crates/fbuild-daemon/src/handlers/operations/deploy.rs
  • crates/fbuild-daemon/src/handlers/operations/monitor.rs
  • crates/fbuild-daemon/src/handlers/websockets.rs
  • crates/fbuild-python/src/json_rpc.rs
  • crates/fbuild-python/src/messages.rs
  • crates/fbuild-python/src/serial_monitor.rs
  • crates/fbuild-serial/src/manager.rs
  • crates/fbuild-serial/src/messages.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/serial-session-rebind

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees merged commit 4cb4c35 into main Jun 18, 2026
90 of 91 checks passed
@zackees zackees deleted the fix/serial-session-rebind branch June 18, 2026 23:38
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

serial manager: transparently rebind active sessions after tracked USB serial renumbering

1 participant