Regenerate from corrected spec (tsoa 6.6.8): drop *Response1 collisions, v5.0.3#14
Open
winrid wants to merge 1 commit into
Open
Regenerate from corrected spec (tsoa 6.6.8): drop *Response1 collisions, v5.0.3#14winrid wants to merge 1 commit into
winrid wants to merge 1 commit into
Conversation
5.0.2 was generated from the tsoa 6.6.7 spec, which emitted every T | APIError return as a union-wrapper response -- producing 60 colliding *Response1 models (e.g. both GetEventLogResponse and GetEventLogResponse1) and X | APIError wrapper return types. fastcomments is now on tsoa 6.6.8, which splits those (182 union responses -> 0). Regenerated from the corrected spec: drops the 60 collision models and switches the affected method return types to the real success types. Keeps moderation tenantId (43) + broadcastId (13) params. Bump 5.0.2 -> 5.0.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates
fastcomments-sdkfrom the current corrected OpenAPI spec (fastcomments on@fastcomments/tsoa@6.6.8).5.0.2(currently on npm) was built from the old tsoa 6.6.7 spec, which emitted everyT | APIErrorreturn as a union wrapper -- producing 60 colliding*Response1models (e.g. bothGetEventLogResponseandGetEventLogResponse1) andX | APIErrorwrapper return types. 6.6.8 splits those (182 union responses -> 0), so this regen:*Response1collision models (GetEventLogResponse1etc.); only 3 legitimate*ResponseAnyOfmodels remain (genuine domain-config anyOf unions).X | APIErrorwrappers to the clean success types.tenantId(43) +broadcastId(13) query params.Mirrors the corrected-spec regen the 10 language SDK PRs received. Not published/tagged -- publish 5.0.3 to npm + git tag + GitHub release after merge.
Note: switching the wrapper return types to clean types is a consumer-visible type change for TS consumers who referenced the wrapper types -- bump to 5.1.0 instead if you'd rather signal that.