Regenerate SDK: Moderation API + grouped request parameters#8
Merged
Conversation
…astId params) Adds the optional tenantId query param to the SSO-gated Moderation API endpoints and the optional broadcastId query param to the mutating moderation endpoints. Backward-compatible. Mirrors fastcomments-sdk-js v5.0.2.
The regen overwrote the hand-written 'API Clients / Using PublicApi / Using ModerationApi' usage section with the generic generated content. Restore it and add README.md to .openapi-generator-ignore so the generator no longer overwrites it (update.sh leaves the ignore file and README.md in place, so the ignore takes effect).
API methods now take a single $associative_array argument (useSingleRequestParameter). update.sh now uses the FastComments openapi-generator fork, since the stock generator ignores the option for php. Updated SSO tests and README examples.
One call still passed positional args to the now-grouped method, tripping array_key_exists on CI (where secrets make the integration tests run).
API methods now take required params + the request body positionally, with optional params in a single $options array (was: one $associative_array for everything). Updated SSO tests + README.
…ere are none deleteNotificationCount($tenant_id, $id) no longer takes an empty $options; deleteModerator($tenant_id, $id, $send_email = null) passes its one optional directly; 2+ optionals still use $options.
…ommentApiResponse rename Moderation endpoints gained a mod_api/ path segment; PostRemoveCommentResponse renamed to PostRemoveCommentApiResponse.
winrid
changed the title
Replace the long capability enumeration with a concise summary.
Bump version to 3.0.0 and regenerate from the new generator fork release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates the PHP client from the latest OpenAPI spec. Two notable changes since the last release:
Grouped request parameters: all API methods now take required parameters and the request body positionally, with an operation's optional parameters that are passed in a trailing
$optionsarray (a lone optional is a direct argument, and operations with none take no extra argument).Moderation API: adds the moderator-dashboard endpoints (listing, searching, counting and exporting comments and logs; moderation actions such as remove/restore/flag and review/spam/approval status; vote adjustments; bans; badges and trust), authenticated with an SSO moderator token.
Model rename:
PostRemoveCommentResponseis renamed toPostRemoveCommentApiResponse.