Conversation
Pin to the 3.0.0 SDK line instead of the wildcard `*`, and update composer.lock (fastcomments-php v1.2.0 -> v3.0.0). No code changes.
The Laravel 10/11 matrix jobs could no longer resolve: with no testbench constraint, composer picks testbench 10 (which now requires Laravel 12) and can't fall back to a non-advisory Laravel 10/11. Pin testbench 8/9/10 to Laravel 10/11/12 so each job resolves the matching framework. Pre-existing drift, surfaced on this PR.
composer config policy.advisories.block false before update: Laravel 10/11 pull advisory-affected framework deps that this package doesn't ship, so the compat matrix shouldn't fail resolution on them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tightens the
fastcomments/fastcomments-phpconstraint from*to^3.0so the package tracks the 3.0.0 SDK line explicitly. No code changes (the package only exposes the SDK via DI/facade; it doesn't call the changed methods).