Add Moderation API and stable response types#1
Merged
Conversation
Regenerated the Dart client from the updated OpenAPI spec (mirrors fastcomments-sdk@4.0.0). - Adds Moderation API (43 moderator-dashboard endpoints) as a separate ModerationApi class (lib/api/moderation_api.dart). All endpoints accept an 'sso' query param. Covers comment moderation, bans, badges & trust factor, and search. - BREAKING: operations now return their success type directly instead of an 'X | APIError' union; APIError is a 'default' error response. Response shapes are unchanged. The old generated '*200Response' wrapper types are removed in favor of the real success types.
winrid
changed the title
Fixes anyOf empty-class syntax and nested-map deserialization that the released generator produces incorrectly. update.py now downloads the generator jar instead of using the npm wrapper.
The client package only has generated model tests; add a small sso_tests package that depends on the client + crypto and exercises the hand-written sso/ helpers: SSO token generation (unit) and live create+fetch via secure SSO (integration).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moderation API
Adds a Moderation API with methods for the moderator dashboard:
All Moderation methods accept an
ssoparameter for SSO-authenticated moderators.Response types (breaking)
Each method now returns its success response type directly, with errors surfaced as a default error response, instead of the previous combined success-or-error return type. The response type names are now stable. Response shapes are unchanged.
Recommend a major version bump.