Implement option to skip svg files with duplicate filenames#143
Open
biser-yordanov wants to merge 2 commits into
Open
Implement option to skip svg files with duplicate filenames#143biser-yordanov wants to merge 2 commits into
biser-yordanov wants to merge 2 commits into
Conversation
Author
|
It may also solve Issue #99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed this option for a big-scale project where different clients can overwrite single icons by using the existing svg filename, but uploading it to a client specific directory.
The implementation may be too simple and I didn't write any tests, but if you could use this branch as a base and implement the option, it'll be great.
Please note that I use
idinstead offilename. This is needed due to Rails naming conventions (we have files likeclose.de_xy.svg, which overwritesclose.svg)