Networktables cleanup#4
Open
Junbotron wants to merge 24 commits into
Open
Conversation
multiple paths, added intermediarypose method
…oldfish into swerve-improvements
(doesn't work)
…n limiting code and changed sigmoid compensation
|
There are a lot of commits in this PR that aren't related to Networktables. Was this work done on the correct starting branch? |
Contributor
Author
|
I first made the new branch networktables-cleanup then set the origin there, and then I made the cleanup commit in that branch. On Source Control in VS all the previous commits are in swerve-improvements, so I'm not sure how I have 24 commits merging into main. |
|
You might've been on a different branch than main, or your local main branch was not fully merged with origin/main when you created the networktables-cleanup branch. Either way, first, we need to get to the bottom of it, then decide how to proceed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed all smartdashboard lines into organized networktables in SwerveBase and TalonFXModule (Every module has its own desired and current velocity and accel stuff).