Implement HTTP file server for SD card access over WiFi#746
Open
DFlak wants to merge 1 commit into
Open
Conversation
mck1117
reviewed
Apr 16, 2026
| chThdCreateStatic(sdCardLoggerStack, sizeof(sdCardLoggerStack), SD_CARD_LOGGER, sdCardLoggerThread, nullptr); | ||
| } | ||
|
|
||
| const char* getActiveLogFileName() { |
mck1117
reviewed
Apr 16, 2026
| }; | ||
|
|
||
| static NO_CACHE ServerSocket tsServer; | ||
| static NO_CACHE ServerSocket tsServer("TS"); |
Collaborator
There was a problem hiding this comment.
HTTP server is unrelated to this file and independent to the wifi TS channel - please put it elsewhere
mck1117
reviewed
Apr 16, 2026
| /*static*/ ServerSocket* ServerSocket::s_serverList = nullptr; | ||
|
|
||
| ServerSocket::ServerSocket() { | ||
| ServerSocket::ServerSocket(const char* name) : m_name(name) { |
Collaborator
There was a problem hiding this comment.
please split the generic ServerSocket changes to their own PR
Collaborator
|
had claude do a review, it found lots of issues: https://gist.github.com/mck1117/c68b41029c4ad75203086b0aa8a0ea5a I'm not really worried about 5 or 8, but the rest are worthy. The stuff in "things done well" for ServerSocket seem good, we should split that to its own PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.